[PATCH] Update .gitignore
by Stef Walter
Although I'm now using srcdir != builddir like a good boy ... here's a
patch which updates .gitignore for completeness.
Cheers,
Stef
10 years, 2 months
[Patch] Cmocka unit test patch for authtok module
by Pallavi Jha
Hi
I have created the patch and attached it with this mail. Kindly review it.
I have commented some of the test as it fails(gives segmentation fault)
when authtoken is NULL. I think we should test tok for NULL before
accessing its elements. Please correct me if am wrong.
for example :
uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
{
return tok->data;
}
This should be written as:
uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
{
if(!tok) {
return EINVAL;
}
return tok->data;
}
Thanking You,
Pallavi
10 years, 2 months
[PATCH] Fix FAST authentication for FreeIPA two-factor authentication case
by Alexander Bokovoy
Hi!
FAST auth is broken for OTP case at least for FreeIPA because krb5_child
returns an empty SSS_OTP message as the last one in the buffer. This message
never got processed by the krb5_child_handler due to the fact that message
size (8 bytes) was triggering the check for buffer length and prematurely
claiming that the whole buffer is malformed.
Fixes https://fedorahosted.org/sssd/ticket/2186 and now I have working ssh logons
with two-factor authentication using native FreeIPA OTP implementation and FreeOTP Android app.
Additionally this patch makes clear how ccache name is passed. It avoids looking into anything
but SSS_PAM_ENV_ITEM message.
--
/ Alexander Bokovoy
10 years, 2 months
DEBUG macro refactoring v3
by Nikolai Kondrashov
Hi everyone,
Please find attached the third version of the DEBUG macro refactoring
patchset. The second version was lost to the maillist message size limit, so
I'll list the changes from the first one:
* level limiting condition moved to the macro as requested by Simo,
* macro definition update is separated from the invocation update,
* automatic macro invocation update is separated from the following manual
fixups,
* invocations using the old debug level (number literals) are updated to
use the new bitmask macros,
* the level conversion function "debug_get_level" is removed.
Please feel free to pick and squash commits as necessary.
Sincerely,
Nick
10 years, 2 months