sssd-devel April 2014

sssd-devel@lists.fedorahosted.org

22 participants
87 discussions

[PATCH] DEBUG macro refactoring - 1.11 backport
by Nikolai Kondrashov 12 May '14

12 May '14

Hi everyone, Here is my backport of the DEBUG macro refactoring patchset to sssd-1-11 branch. Patches are mostly identical to master, with the exception of the changes generated by scripts (which were re-run), some commit messages and one commit being moved into a more logical place in history. All patches that should work passed "make check" both on RHEL7 and Fedora 20 (verified by CI). I've left the original Reviewed-by tags for the commits with unchanged content, but I can remove them, if necessary. Sincerely, Nick

4 11

[PATCH] LDAP: Check the LDAP handle before using it
by Jakub Hrozek 12 May '14

12 May '14

Hi, the attached patch adds checks that should "fix" https://fedorahosted.org/sssd/ticket/2305 so that SSSD errors out instead of crashing. It's basically copy-and-paste of 5fe6ca5e339fd345119752e996c14edf8db57660 just in another code area. Because we were never able to reproduce the crash and never had any logs, my testing only consisted of making sure that bind works.

2 3

[PATCH] ipa_selinux: Put SELinux map order related variables into structure
by Michal Židek 12 May '14

12 May '14

Resolves: https://fedorahosted.org/sssd/ticket/2304 I also renamed the create_order_array() function into init_map_order_ctx. It seems to be more appropriate name now. Patch is attached. Thanks, Michal

2 4

[PATCH] MONITOR: Fix start up with closed standard input
by Lukas Slebodnik 12 May '14

12 May '14

ehlo, The attached patch fixes my use case. (sssd in container without tty) I am not sure whether other processes use stdin, therefore I disable monitorin of stdin only in main process. LS

4 6

[PATCHES][ding-libs] Bump versions for 0.4.0 release
by Lukas Slebodnik 09 May '14

09 May '14

ehlo, release blocked by: https://lists.fedorahosted.org/pipermail/sssd-devel/2014-April/019043.html Two patches are attachd. My notes: basicobject no ABI change new function added simplebuffer_get_vbuf libref_array no ABI change function ref_array_debug added to public header ref_array.h libcollection version-info should be 4:0:0, but there would be big jump in soname libcollection.so.2.1.0 -> libcollection.so.4.0.0 -function removed from ABI: col_allocate_item (declared in collection_priv.h) libini_config version-info should be 5:0:0, but there would be big jump in soname libini_config.so.3.1.0 -> libini_config.so.5.0.0 -functions removed from ABI:collect_metadata, empty_section, ini_boundary_cb, ini_cleanup_cb, ini_comment_cb, ini_get_error_str,is_allowed_spaces. is_just_spaces, parser_run, prepare_metadata, print_grammar_errors, print_validation_errors, read_line, valid_collision_flags //were declared in internal ini_metadata.h or ini_config_priv.h LS

3 6

[PATCH] Extend the LDAP attribute map with custom options
by Jakub Hrozek 06 May '14

06 May '14

Hi, the attached patches implement ticket #2073 -- the possibility to extend the LDAP attribute map with custom attributes. All attributes are saved to sysdb with the 'extra_' prefix so that the custom attributes can be distinguished from the sysdb schema. The first patch fixes a mostly unrelated bug, which I found when writing unit tests. [PATCH 1/3] LDAP: Fix one-by-one bug in sdap_copy_opts The sdap_copy_opts function copied all the arguments except for the sentinel. [PATCH 2/3] LDAP: Make it possible to extend an attribute map https://fedorahosted.org/sssd/ticket/2073 This commit adds a new option ldap_user_extra_attrs that is unset by default. When set, the option contains a list of LDAP attributes the LDAP provider would download and store in addition to the usual set. The attributes are fetched in sysdb with the 'extra_' prefix to not conflict with the sssd sdap maps. [PATCH 3/3] Make LDAP extra attributes available to IPA and AD https://fedorahosted.org/sssd/ticket/2073

8 18

Re: [SSSD] [PATCH] Extend the LDAP attribute map with custom options
by Jakub Hrozek 02 May '14

02 May '14

On Fri, Apr 25, 2014 at 12:05:23PM +0200, Jan Pazdziora wrote: > On Fri, Apr 25, 2014 at 11:42:14AM +0200, Jakub Hrozek wrote: > > > > I don't really mind too much and appears Jan does not either. So I > > simply swapped the order in the attached patches, now it's sysdb:LDAP. > > > > Man page was changed accordingly. > > > > Jan, could you check if the man page change (src/man/sssd-ldap.5.xml in > > the second patch) reads good to you? > > [...] > > > ldap_user_uid_number = str, None, false > > diff --git a/src/man/sssd-ldap.5.xml b/src/man/sssd-ldap.5.xml > > index f93b418c45d9bcd32499860a858c3f829bb245ca..6426fe4fca5dc9bb9bc84fcbf633404144052d01 100644 > > --- a/src/man/sssd-ldap.5.xml > > +++ b/src/man/sssd-ldap.5.xml > > @@ -616,6 +616,54 @@ > > </listitem> > > </varlistentry> > > > > + <varlistentry> > > + <term>ldap_user_extra_attrs (string)</term> > > + <listitem> > > + <para> > > + Comma-separated list of LDAP attributes that SSSD > > + would fetch along with the usual set of user > > + attributes. > > + </para> > > + <para> > > + The list can either contain LDAP attribute names > > + only, or colon-separated tuples of SSSD cache > > + attribute name and LDAP attribute name. In > > + case only LDAP attribute name is specified, > > + the attribute is saved to the cache verbatim. > > + Using a custom SSSD attribute name might be > > + required by environments that configure several > > + SSSD domains with different LDAP schemas. > > + </para> > > + <para> > > + Please note that several attribute names are > > + reserved by SSSD, notably the <quote>name</quote> > > + attribute. SSSD would report an error if any of > > + the reserved attribute names is used as an extra > > + attribute name. > > + </para> > > + <para> > > + Examples: > > + </para> > > + <para> > > + ldap_user_extra_attrs = telephoneNumber > > + </para> > > + <para> > > + Save the <quote>telephoneNumber</quote> attribute from LDAP > > + as <quote>telephoneNumber</quote> to the cache. > > + </para> > > + <para> > > + ldap_user_extra_attrs = phone:telephoneNumber > > + </para> > > + <para> > > + Save the <quote>telephoneNumber</quote> attribute from LDAP > > + as <quote>phone</quote> to the cache. > > + </para> > > + <para> > > + Default: not set > > + </para> > > + </listitem> > > + </varlistentry> > > It reads very well. > > Once I have stable .src.rpm, I'll test if the behaviour matches the > man page as well. Hi, can I get a final ACK (or a non-file NACK :-)) on the patches?

3 4

[PATCHES] AD provider: fix use after free & uninitialized variable
by Pavel Reichl 02 May '14

02 May '14

Hello, while working on #2332 I found these 2 bugs. Unfortunately they weren't the cause of problem, but bugs anyway. Please see attached patches. Pavel Reichl

4 6

RFC: Backporting Nikolai's DEBUG patches to sssd-1-11
by Jakub Hrozek 30 Apr '14

30 Apr '14

Hi, we've been keeping the sssd-1-11 branch fairly conservative recently, mostly as a precaution to not break downstreams that consume sssd-1-11, like RHEL. But some relatively larger features, such as the InfoPipe responder, need to be backported to sssd-1-11 (and by extension to RHEL-6) now. One large difference between master and sssd-1-11 are the DEBUG messages and I'd like to propose that we backport the new DEBUG messages to sssd-1-11 and mass-convert the callers the same way we did in master. I think backporting the DEBUG messages change would be relatively low-risk, as the messages don't generally affect the behaviour of the daemon. The big downside of course is that we break git-blame and cause a bit of churn in sssd-1-11. But I think this downside it outweighted by not having to backport each and every DEBUG message from patches we'll be pulling in from master to sssd-1-11, which is all the SBUS changes Stef did recently and also all the work on the IFP responder. The next step would be backporting the SBUS changes, but I'd prefer a separate thread about those. Thoughts?

5 6

SSSD CIM schema for OpenLMi
by Pavel Březina 30 Apr '14

30 Apr '14

Hi, attached is a CIM schema for SSSD provider. This schema was acked by OpenLMI developers. The first version of OpenLMI provider will provider methods to enable/disable SSSD components and basic information about domains. I hope I don't have to explain the MOF language to developers so I will just say that association classes models relationships between other entities. Feel free to ask me anything if needed.

2 6

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel April 2014