sssd-devel January 2015

sssd-devel@lists.fedorahosted.org

18 participants
89 discussions

Start a nNew thread

[PATCH] TESTS: typo in 'assert message'
by Pavel Reichl 08 Jan '15

08 Jan '15

Please see this trivial patch. Thanks.

3 2

SSSD patch
by Carlos Munoz 08 Jan '15

08 Jan '15

Hi, I am currently working on migrating SSSD translations to Zanata and am submitting the attached patch per the instructions on the project's wiki. The patch includes the addition of a Zanata client configuration file so translations can be pushed / pulled from the Zanata server. the project has already been created in Zanata (https://fedora.zanata.org/project/view/sssd) Let me know if you have any questions. Regards, -- Carlos A. Munoz Software Engineering Supervisor Engineering - Internationalization Red Hat

2 5

[PATCH] monitor: Service restart fixes
by Stephen Gallagher 07 Jan '15

07 Jan '15

There are actually two bugs here: 1) When either the kill(SIGTERM) or kill(SIGKILL) commands returned failure (for any reason), we would talloc_free(svc) which removed it from being eligible for restart, resulting in the service never starting again without an SSSD service restart. 2) There is a fairly wide race condition where it's possible for a SIGKILL timer to "catch up" to the child exit handler between us noticing the termination and actually restarting it. The race happens because we re-enter the mainloop and add a restart timeout to avoid a quick failure if we keep restarting due to a transitory issue (the mt_svc object, and therefore the SIGKILL timer, were never freed until we got to the actual service restart). We can minimize this race by recording the timer_event for the SIGKILL timeout in the mt_svc object. This way, if the process exits via SIGTERM, we will immediately remove the timer for the SIGKILL. This patch also removes the incorrect talloc_free(svc) calls on the kill() failures and replaces them with an attempt to just start up the service again and hope for the best. Resolves: https://fedorahosted.org/sssd/ticket/2525

3 3

[PATCH] Add test for sysdb_store_override
by Sumit Bose 07 Jan '15

07 Jan '15

Hi, this is just a test for one of the new view/override related sysdb calls. bye, Sumit

2 3

Data dir and cwrap tests
by Nikolai Kondrashov 07 Jan '15

07 Jan '15

Hi everyone, In order to run integration tests as non-root we would need to have all data directories and files to reside in a user-writeable (temporary) directory. However, it seems that various sssd data directory and file locations are spread over the code as preprocessor macros, resulting in static strings. See the output of this command executed in a build dir: find -type f -perm -111 -name '*.so*' -or -name 'lt-*' | xargs strings -f | grep var/lib/sss Making this changeable at runtime doesn't seem to be practical. Replacing all these in binaries after build somehow is not easy to do reliably. So, are we left with forgoing the idea of running cwrap tests under "make check" and relying on a special-prefix build in "contrib/ci/run", or could there be some other ways? It could be "fakechroot", but it is not in RHEL repos, it seems, and I'm not sure how well it will work and how easy it will be to setup and maintain the required directory tree and files. Thank you. Nick

4 30

[PATCH] SYSDB: sysdb_search_object_by_sid should return ENOENT
by Lukas Slebodnik 07 Jan '15

07 Jan '15

ehlo, Pavel wanted to send patch in different thread. LS

3 3

[RFC] LDAP integration tests design
by Nikolai Kondrashov 06 Jan '15

06 Jan '15

Hi everyone, I've finished the draft for the design of LDAP integration tests: https://fedorahosted.org/sssd/wiki/DesignDocs/CwrapLDAP I would be grateful for any suggestions, comments or corrections. Thank you. Nick

2 1

[PATCH] CONFDB: Typo in debug message
by Pavel Reichl 05 Jan '15

05 Jan '15

Please see simple patch on typo found by Kaushik. Thanks. <mailto:kbanerje@redhat.com>

3 2

[PATCH] ldap: use case insensitive check
by Arjun Sreedharan 05 Jan '15

05 Jan '15

Signed-off-by: Arjun Sreedharan <arjun024(a)gmail.com> --- src/providers/ldap/ldap_id_cleanup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/ldap/ldap_id_cleanup.c b/src/providers/ldap/ldap_id_cleanup.c index f78d4b4..88e487b 100644 --- a/src/providers/ldap/ldap_id_cleanup.c +++ b/src/providers/ldap/ldap_id_cleanup.c @@ -361,7 +361,7 @@ static int cleanup_groups(TALLOC_CTX *memctx, } posix = ldb_msg_find_attr_as_string(msgs[i], SYSDB_POSIX, NULL); - if (!posix || strcmp(posix, "TRUE") == 0) { + if (!posix || strcasecmp(posix, "TRUE") == 0) { /* Search for users that are members of this group, or * that have this group as their primary GID. * Include subdomain users as well. -- 1.7.11.7

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel January 2015