sssd-devel November 2015

sssd-devel@lists.fedorahosted.org

12 participants
80 discussions

[PATCH] Guard against invalid DP messages
by Jakub Hrozek 14 Nov '15

14 Nov '15

Hi, the two attached patches fix https://fedorahosted.org/sssd/ticket/2861 The first removes dp_pam_err_to_string() completely. It was wrong to use function that calls pam_strerror() for non-PAM callbacks and even worse that the PAM callback itself didn't call dp_pam_err_to_string.. The second guards against similar mistakes in the future by checking for valid UTF-8 string. I think we should do this because technically there can be a 3rd party provider. I also have another patch that reduced code duplication -- because I suspect that copy-pasting was the original reason this bug was introduced. But I need to test the patches more, because they touch all callbacks..

3 13

[PATCH] test_sysdb_subdomains: Do use assignment in assertions
by Lukas Slebodnik 14 Nov '15

14 Nov '15

ehlo, I found these iisues due to different size of integer and pointer on el6. /home/build/sssd/src/tests/cmocka/test_sysdb_subdomains.c:248: error: cast from pointer to integer of different size Simple patch is attached. LS

2 3

[PATCH] SSSD: Add a new command diag_cmd
by Jakub Hrozek 13 Nov '15

13 Nov '15

Hi, I created this patch to try to diagnose an issue where sssd would randomly restart on any of machines in a VM cluster without giving too much advise why. I think it might be useful to merge in general.

4 15

[PATCH] AD: remove annoying debug message
by Pavel Březina 12 Nov '15

12 Nov '15

Simple patch is attached.

2 2

[PATCHES] sssd_client: Do not use removed memory cache
by Lukas Slebodnik 12 Nov '15

12 Nov '15

ehlo, attached patches fix issue with memory cache in integration tests. https://fedorahosted.org/sssd/ticket/2726 LS

3 5

CONFIGURE: Bump AM_GNU_GETTEXT_VERSION
by Lukas Slebodnik 12 Nov '15

12 Nov '15

ehlo, The function gettext was not detected properly with strict cflags even thought it was part of glibc. sh$ CFLAGS="-Werror" ./configure sh$ grep gt_cv_func_gnugettext config.log gt_cv_func_gnugettext1_libc=no gt_cv_func_gnugettext1_libintl=no sh$ objdump -T /lib64/libc.so.6 | grep gettext 000000000002fc60 w DF .text 0000000000000010 GLIBC_2.2.5 dcngettext 000000000002dc70 w DF .text 000000000000000f GLIBC_2.2.5 dcgettext 000000000002fc80 w DF .text 0000000000000016 GLIBC_2.2.5 ngettext 000000000002dc90 w DF .text 000000000000000f GLIBC_2.2.5 gettext 000000000002dc70 g DF .text 000000000000000f GLIBC_2.2.5 __dcgettext 000000000002dc80 w DF .text 000000000000000a GLIBC_2.2.5 dgettext 000000000002dc80 g DF .text 000000000000000a GLIBC_2.2.5 __dgettext With attached patch situation is better. q sh$ autoreconf sh$ CFLAGS="-Werror" ./configure sh$ grep gt_cv_func_gnugettext config.log gt_cv_func_gnugettext1_libc=yes LS

2 2

[PATCH] TESTS: extend PAM responder unit test
by Pavel Reichl 12 Nov '15

12 Nov '15

Hello, please see first iteration of extended PAM responder unit tests.

4 30

[PATCHES]: Add a sketch of Samba AD DC tests
by Nikolai Kondrashov 11 Nov '15

11 Nov '15

Hi everyone, I've worked on Samba integration tests for a while and here is where I got thus far. I'll need to resume my work on Session Recording [1] for now and will be happy if someone took the Samba work over. If not I'll return to it some time in the future. The attached patches add very rudimentary Samba AD DC instance setup and teardown, and a very basic test, plus the requisite changes. They require Samba built with AD DC support, which is missing from RHEL/Fedora repos, but can conveniently be acquired from Lukas's COPR repo (Thanks, Lukas!): https://rhcopr-devel.lab.eng.brq.redhat.com/coprs/lslebodn/samba4/ The patches were confirmed working on Fedora 22 and Debian Testing. The latter had resolv_wrapper installed manually, since it's not in Debian repos yet. Among the things we still have to do are: * Make Samba packages with AD DC support available for developers on Fedora/RHEL. Add instructions for getting them to contrib/ci/README.md and maybe somewhere else as well, if that's different from the already existing COPR repo. * Add support for disabling SSSD netlink use, perhaps with an environment variable which can then be set in src/tests/intg/Makefile.am. See https://fedorahosted.org/sssd/ticket/2860 * Deliver resolv_wrapper to Debian package repos. * Write the actual tests. Thanks everyone who helped me get this far! Hope we get this working and merged eventually :) Nick [1] http://spbnick.github.io/2015/10/26/open-source-session-recording.html

1 0

[PATCH] cache_req: check all domains for lookups by certificate
by Sumit Bose 11 Nov '15

11 Nov '15

Hi, this patch is the equivalent of 374268c5eda35e8bbc2fef30752299199439cffe "fix upn cache_req for sub-domain users" for lookups by certificates. bye, Sumit

3 4

[PATCHES] UTIL: Fix memory leak in switch_creds
by Lukas Slebodnik 11 Nov '15

11 Nov '15

ehlo, You can see a leak in talloc report. But it was ignored. So we didn't notice it for long time. http://sssd-ci.duckdns.org/logs/job/29/90/rhel7/ci-build-debug/src/tests/cw… The first patch fixes the leak and the last one is prevention for such mistakes in future. LS

3 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2015