sssd-devel March 2015

sssd-devel@lists.fedorahosted.org

15 participants
74 discussions

[PATCH] sdap: properly handle binary objectGuid attribute
by Sumit Bose 24 Mar '15

24 Mar '15

Hi, this patch tries to resolve https://fedorahosted.org/sssd/ticket/2588 by properly handling binary objectGUID values. In general there shouldn't be an issue because this ID is not used for AD user. But if the binary value starts with 0x00 there might be issues saving the user object to the cache. bye, Sumit

2 9

[PATCH] RFC: Support both cmocka 1.0 and pre-1.0 API at the same time
by Jakub Hrozek 24 Mar '15

24 Mar '15

Hi, the attached two patches add a way to detect pre-1.0 cmocka and adds compatible definitions in the first patch and uses them to convert a single unit test. I found the approach ugly myself, so much that I'm considering converting all cmocka-based tests to cmocka-1.0 and don't compile the cmocka tests at all unless 1.0 or later is present on the system. It's not functionality after all, "just" tests and for CI we could add cmocka-1.0 to the CI system ourselves.. Opinions?

4 24

[PATCHES] ldap: refactor - reuse sss_utc_to_time_t()
by Pavel Reichl 23 Mar '15

23 Mar '15

Hello, I recently introduced new utility function sss_utc_to_time_t(). This patches should refactor some existing code to reuse it. 1st patch - add unit tests for fuctions to be amended. 2nd patch - amends check_pwexpire_kerberos() and modifies test - to clearly show how has behavior changed. 3rd patch - amends nds_check_expired() - no test changes required ci of this version of patches has passed. http://sssd-ci.duckdns.org/logs/job/10/95/summary.html Thanks!

2 9

[PATCH] memberof: Do not create request with 0 attribute values
by Lukas Slebodnik 23 Mar '15

23 Mar '15

ehlo, at first I thought it is related to ticket "#2576" but after simplification of reproducer I found out it just looks bad in log file. ldb failed to add attribute with 0 values to ldb entry, but it would not have any effect. BTW The best would be to immediately skip request. I'm not sure how to do it with plain ldb. How to reproduce? * import attached ldif * getent group "Escalation" * sss_cache -E * getent group "Escalation" BTW you can see more warnings if nested hierarchy is deeper and each group directly contains the same user. LS

2 2

[PATCH] Make several LDAP operation timeouts configurable
by Jakub Hrozek 23 Mar '15

23 Mar '15

Hi, the attached patches resolve https://fedorahosted.org/sssd/ticket/1501 They were confirmed to work by a user affected by a long timeout. I was looking if unit tests would help, but they would mostly only test if sdap_op_timeout() is called as it should. I'm not sure it's worth it. I also think it's enough to observe the timeouts to be displayed in DEBUGs after the last patch is applied.

3 6

[PATCH] LDAP: remove unused code
by Pavel Reichl 23 Mar '15

23 Mar '15

> On Thu, Mar 19, 2015 at 03:18:11PM +0100, Pavel Reichl wrote: >> On 03/10/2015 03:43 PM, Sumit Bose wrote: >>> @@ -1982,6 +1986,36 @@ static void sdap_get_groups_process(struct tevent_req *subreq) >>> return; >>> } >>> + if (state->no_members) { >>> + ret = sysdb_attrs_primary_name_list(state->sysdb, state, >>> + state->groups, state->count, >>> + state->opts->group_map[SDAP_AT_GROUP_NAME].name, >>> + &groupnamelist); >>> + if (ret != EOK) { >>> + DEBUG(SSSDBG_OP_FAILURE, >>> + "sysdb_attrs_primary_name_list failed.\n"); >>> + tevent_req_error(req, ret); >>> + return; >>> + } >>> + >>> + ret = sdap_add_incomplete_groups(state->sysdb, state->dom, state->opts, >>> + groupnamelist, state->groups, >>> + state->count); >>> + if (ret == EOK) { >>> + DEBUG(SSSDBG_TRACE_LIBS, >>> + "Reading only group data without members successful.\n"); >>> + tevent_req_done(req); >>> + } else { >>> + DEBUG(SSSDBG_OP_FAILURE, "sdap_add_incomplete_groups failed.\n"); >>> + tevent_req_error(req, ret); >>> + } >>> + return; >> unused code starts here >>> + >>> + ret = sdap_save_groups(state, state->sysdb, state->dom, state->opts, >>> + state->groups, state->count, false, >>> + NULL, true, NULL); >>> + } >>> + >> Hello, >> >> coverity found this unused code - is it OK to just remove sdap_save_groups() > yes, please remove it. While you are at it I wonder if you can fix the > debug message (s/Reading/Writing/) above as well? > > bye, > Sumit > Please see this trivial patch. Thanks!

2 3

[PATCH] GPO: error out instead of leaving array element uninitialized
by Sumit Bose 23 Mar '15

23 Mar '15

Hi, this patch should fix a segfault which was recently found in the GPO code. bye, Sumit

2 3

[PATCH] KRB5: add debug hint
by Pavel Reichl 20 Mar '15

20 Mar '15

While testing some patches I could not authenticate as IPA user, problem was that there was time skew about 30 minutes between IPA server and IPA client. Attached patch should provide clear hint about this possibility. Thanks.

3 5

[PATCH] IPA: make sure output variable is set
by Sumit Bose 19 Mar '15

19 Mar '15

Hi, Steeve found another issue while testing with older FreeIPA server versions. This patch should fix it. bye, Sumit

3 6

[PATCH] IPA: set EINVAL if dn can't be linearized
by Pavel Reichl 19 Mar '15

19 Mar '15

Please see attached trivial patch. Thanks. PS: feel free to squeeze it into Sumit's patch from 'IPA: make sure output variable is set'

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel March 2015