Looks good, ACK.
On Thu, Jul 7, 2016 at 4:39 AM, Michal Židek <mzidek(a)redhat.com> wrote:
> On 07/04/2016 06:28 PM, Michal Židek wrote:
>
>> On 07/01/2016 10:34 PM, Dan Lavu wrote:
>>
>>> I couldn't apply your patch to my repo, so I just modified the text in
>>> your patch. I have a question though, will this be the new default
>>> behavior for sssd 1.4.x onwards in Fedora and RHEL? Also I think the
>>> feature, being called "merging" is not very accurate, I think it should
>>> be 'include additional configuration files' or 'read additional
>>> configuration files', merging suggests that it will merge the
>>> configuration files into one file... thanks to Git. ;)
>>>
>>> Dan
>>>
>>>
>> Hi Dan,
>>
>> thank you for the new wording.
>>
>> I agree that calling the feature config file
>> merging could be confusing, so I used the verb
>> "include" instead of "merge" and changed the section
>> name.
>>
>> I also removed the SSSD version reference as Lukas
>> suggested.
>>
>> Otherwise the wording should be the same as you
>> proposed.
>>
>> To your question. Yes, this is going to be default
>> behavior with all new SSSD versions compiled with
>> new libini.
>>
>> See the attached patch.
>>
>> Michal
>>
>>
> Sorry, I forgot to CC Dan.
>
> Michal
>