[sssd PR#213][opened] intg: Remove bashism from intgcheck-prepare
by lslebodn
URL: https://github.com/SSSD/sssd/pull/213
Author: lslebodn
Title: #213: intg: Remove bashism from intgcheck-prepare
Action: opened
PR body:
"""
env variable UID is not defined in all shells (eg. dash)
================================ FAILURES ===================================
________________________ test_kcm_mem_init_list_destroy ________________________
Traceback (most recent call last):
File "/home/build/sssd/src/tests/intg/test_kcm.py", line 198, in test_kcm_mem_init_list_destroy
kcm_init_list_destroy(testenv)
File "/home/build/sssd/src/tests/intg/test_kcm.py", line 183, in kcm_init_list_destroy
exp_ccname = testenv.ccname()
File "/home/build/sssd/src/tests/intg/test_kcm.py", line 45, in ccname
my_uid = self.my_uid()
File "/home/build/sssd/src/tests/intg/test_kcm.py", line 41, in my_uid
return int(s_myuid)
ValueError: invalid literal for int() with base 10: ''
And we already use different approach in top level Makefile.am
3488) $(INTGCHECK_CONFIGURE_FLAGS) \
3489) CFLAGS="$$CFLAGS $(AM_CFLAGS) -DKCM_PEER_UID=$$(id -u)"; \
3490) $(MAKE) $(AM_MAKEFLAGS) ; \
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/213/head:pr213
git checkout pr213
7 years, 1 month
[sssd PR#212][opened] intg: fix configure failure with strict cflags
by lslebodn
URL: https://github.com/SSSD/sssd/pull/212
Author: lslebodn
Title: #212: intg: fix configure failure with strict cflags
Action: opened
PR body:
"""
The warning -Wstrict-prototypes is a part of AM_CFLAGS which was appended
for CFLAGS in make target intgcheck-prepare. And combination with
strict CFLAGS in environment variable (e.g. -Werror) caused failures.
sh$ CFLAGS="-Werror" make intgcheck-prepare
checking for gcc... gcc
checking whether the C compiler works... no
configure: error: in `/home/build/sssd/ci-build-debug/intg/bld':
configure: error: C compiler cannot create executables
configure:3719: checking whether the C compiler works
configure:3741: gcc -g3 -O2 -Werror -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-s
trings -Wundef -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs -fno-strict-aliasing -std=gnu99 -DKCM_PEER_UID=1000 conftest.c >&5
conftest.c:11:1: error: function declaration isn't a prototype [-Werror=strict-prototypes]
main ()
^~~~
cc1: all warnings being treated as errors
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/212/head:pr212
git checkout pr212
7 years, 1 month
[sssd PR#197][comment] KCM responder
by jhrozek
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
Pushed to master:
* e89ba95737202d551db2c9524127e6c4cf308796
* 2b5518eeaacc6245cfa77ee4a7086f16208060fc
* 35c9dfe9ba78d3a635cd1af0fb6349ba44344623
* cac0db2f8004ae88b9263dc3888a11a2d3d3d114
* c9db8b8b19827c3d492b8d2769aa77a37dbc12d3
* 60612b5fbdaaa62ebe6c7f4c27200316f08506d6
* 73ce539aa70f43ccd5302b3ef8a02ff028558b12
* 8bb2fcbce7c3fcfd986f1bc835fbcc43ac7cd9d1
* 0700118d8388c38b8cb28279510b206b76a3a411
* ba89271f594e5ed381b4dcb876a2d2787cf51902
* 1ec4198f38d34a1f82a2db55d8c9782a434fb55f
* 70fe6e2bb398b8669ad1aebeaf0abcbffc307475
* bea0dc79faf609de8603cb42f190adae544bc8fb
* 9dcdbf596e138df3eec202487549a67cd3b0091b
* b9c563c29243291f40489bb0dcbf3946fca72d58
* 1dbf09404e20b6e30a24afe72b6d349734aee62f
* 5f7f45a64bdb9353f15b945db4ad2564b4b28ab2
* 4f511a4c5f0084e22ce4c7613f1b279533c68cc5
* c194e8d7cad0184d710d9979e9f12d5cfe176f4a
* 24889dc5e7eb7bc992ab0fa05edfdfa1d157131a
* 3a4a88259ba90d3dc45c1adbbfd39bd7c0204a12
"""
See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-289382353
7 years, 1 month