[sssd PR#211][opened] IFP: Fix of limit = 0 (unlimited result)
by celestian
URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: opened
PR body:
"""
If we set limit to 0 it means that result is unlimited. Internally we
restrict number of result by allocation of result array.
In unlimited case there was a bug and zero array was allocated.
This fix allocates neccessary array when we know real result size.
Resolves:
https://pagure.io/SSSD/sssd/issue/3306
How to test (this reproducer needs #208 "IFP: Filter with * in Users.ListByName method" applied)
```
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*"
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service
sudo su -c "truncate -s0 /var/log/sssd/*.log"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByName \
string:"*" uint32:"0"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Groups \
org.freedesktop.sssd.infopipe.Groups.ListByName \
string:"*" uint32:"100"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByDomainAndName \
string:"domain.cygnus" string:"*" uint32:"100"
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211
6 years, 8 months
[sssd PR#202][opened] T3315 infopipe group users master
by celestian
URL: https://github.com/SSSD/sssd/pull/202
Author: celestian
Title: #202: T3315 infopipe group users master
Action: opened
PR body:
"""
Reproducer is:
```
# PREPARING
ipa user-add --first=Test --last=User --email=u1(a)test-domain.sssd test_user
ipa group-add test_group
# REPRODUCER
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*"
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service
ipa group-add-member --users=test_user test_group
sss_cache -UG
getent group test_group
# getent show user test_user in test_group, but dbus call doesn't:
dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Groups \
org.freedesktop.sssd.infopipe.Groups.FindByName \
string:test_group
# command above returns <RESULT_OBJECT>
# We need to update group in cache because method "org.freedesktop.DBus.Properties.GetAll"
# doesn't update records (<-- this should be better commented)
dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe \
<RESULT_OBJECT> \
org.freedesktop.sssd.infopipe.Groups.Group.UpdateMemberList
# --> this call doesn't work without patch "IFP: Parse ghost name in Group.UpdateMemberList"
# after this call group is updated in cache and we can call:
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
<RESULT_OBJECT> \
org.freedesktop.DBus.Properties.GetAll \
string:"org.freedesktop.sssd.infopipe.Groups.Group"
# We expect test_user in result users array.
# CLEANING
ipa group-del test_group
ipa user-del test_user
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/202/head:pr202
git checkout pr202
6 years, 8 months
[sssd PR#208][opened] IFP: Filter with * in Users.ListByName method
by celestian
URL: https://github.com/SSSD/sssd/pull/208
Author: celestian
Title: #208: IFP: Filter with * in Users.ListByName method
Action: opened
PR body:
"""
This patch fixed asterisk in filter of Users.ListByName method.
Resolves:
https://pagure.io/SSSD/sssd/issue/3305
How to test
```
# We have sssd configured and there are some users
# Wee need also ifp service enabled in sssd.conf
# Restart sssd
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*"
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service
sudo su -c "truncate -s0 /var/log/sssd/*.log"
# It will return users (without patch, it will crash).
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByName \
string:"*" uint32:"100"
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/208/head:pr208
git checkout pr208
6 years, 8 months
[sssd PR#32][opened] Requesting a pull to SSSD:master from fidencio:wip/#3138
by fidencio
URL: https://github.com/SSSD/sssd/pull/32
Author: fidencio
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Action: opened
PR body:
"""
This patch series is intended to solve #3138 by adding a new service
that updates the confdb. As part of the series this service is used by
secrets service.
I only ran CI locally and the two secrets tests have been failing. /o\
Also, I've noticed some weird behavior, where the sssd-update-confdb
service starts for apparently no reason, when upgrading fedora
packages.
Anyways, these pieces of code really need some detailed review as it
was the first time I've been "seriously" playing with TEvent requests.
So, please, consider it more like an RFC than a well finished and
polished code.
Best Regards,
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/32/head:pr32
git checkout pr32
6 years, 9 months
[sssd PR#244][opened] KCM: Modify krb5 snippet file kcm_default_ccache
by lslebodn
URL: https://github.com/SSSD/sssd/pull/244
Author: lslebodn
Title: #244: KCM: Modify krb5 snippet file kcm_default_ccache
Action: opened
PR body:
"""
The file kcm_default_ccache must enable KCM ccache by default
without any modification of the file.
The patch also fixes few issues.
* /etc/krb5.conf.d is fedora/el7 specific and therefore should not
be created by make. File will be installed to $datadir/sssd-kcm by
default
* /etc/krb5.conf.d/ should not be owned by sssd-kcm because it is owned
by dependency of sssd-kcm (krb5-libs)
sh$ rpm -qf /etc/krb5.conf.d/
sssd-kcm-1.15.3-0.20170411.0929.gitdbeae4834.fc26.x86_64
krb5-libs-1.15.1-7.fc26.x86_64
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/244/head:pr244
git checkout pr244
6 years, 9 months