URL: https://github.com/SSSD/sssd/pull/378
Author: fidencio
Title: #378: [RFC] Use GNULIB's compiler warning code
Action: opened
PR body:
"""
This is the 3rd tentative to have this patch reviewed. For more references, please, see: PR #50.
So, I've re-worked those patches a little bit and here is the time difference when running reconfing with the patches:
```
real 0m26.047s
user 0m21.318s
sys 0m4.635s
```
And now without:
```
real 0m25.565s
user 0m20.696s
sys 0m4.433s
```
This patch set is rebased on top of PR #377.
I really would appreciate if someone could review and give their opinion.
The reason this PR was blocked is because this time difference has been considered a "performance issue".
@jhrozek , could you take a look on this?
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/378/head:pr378
git checkout pr378
URL: https://github.com/SSSD/sssd/pull/481
Author: amitkumar50
Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn
Action: opened
PR body:
"""
-Wsuggest-attribute=noreturn warns about functions that might
be candidates for attributes "pure", "const" or "noreturn".
Warning will be thrown if a function returns contain an infinite
loop or return abnormally by throwing, calling "abort" or trapping.
Here we are sure that functions will not return we can use
GCC variant: __attribute__((__noreturn__))
Resolves: https://pagure.io/SSSD/sssd/issue/3604
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/481/head:pr481
git checkout pr481
URL: https://github.com/SSSD/sssd/pull/515
Author: amitkumar50
Title: #515: sssctl: Showing help even when sssd not configured
Action: opened
PR body:
"""
Current Issue:
On a clean and unconfigured system, it's not possible
to use --help.
`# dnf install sssd-tools`
`# sssctl cache-remove --help`
Shows:
[confdb_get_domains] (0x0010): No domains configured, fatal error!
Solution: Donot check for confdb initialization when sssctl 3rd
command line argument passed is '--help'.
Please note when we run 'sssctl --help' on unconfigured system
confdb check is not done and proper o/p is seen.
Also suggest if we have better alternative..
Resolves: https://pagure.io/SSSD/sssd/issue/3634
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/515/head:pr515
git checkout pr515
URL: https://github.com/SSSD/sssd/pull/539
Author: sumit-bose
Title: #539: Make nss netgroup requests more robust
Action: opened
PR body:
"""
I currently do not have a good reproducer for any issue but I hope to commit
messages can explain why I think the two patches make sense.
Related to https://pagure.io/SSSD/sssd/issue/3679
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/539/head:pr539
git checkout pr539
URL: https://github.com/SSSD/sssd/pull/485
Author: justin-stephenson
Title: #485: Support alternative sources for the files provider
Action: opened
PR body:
"""
This PR allows the configuration of different(one or multiple) passwd and group files to be managed by the files provider with new options `alt_passwd_files` and `alt_group_files`.
Primary testing steps include ensuring that alternate passwd and group entries are consistently accessible with 'getent -s sss' commands, and testing that inotify watches dynamically detect changes to any alternate source files.
Ticket: https://pagure.io/SSSD/sssd/issue/3402
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/485/head:pr485
git checkout pr485
URL: https://github.com/SSSD/sssd/pull/544
Author: jhrozek
Title: #544: IPA: Qualify the externalUser sudo attribute
Action: opened
PR body:
"""
We broke the externalUser support with the introduction of the fully
qualified attributes, because the provider was saving the data verbatim,
but the sudo responder expects a fully qualified name.
Reproducer:
on the server:
ipa sudocmd-add --desc='For reading log files' /usr/bin/less
ipa sudorule-add readfiles
ipa sudorule-add-user --users=lcluser
ipa sudorule-mod --hostcat=all readfiles
then on the client:
configure sssd with:
id_provider = files
sudo_provider = ipa
ipa_domain = ipa.test
run:
sudo useradd lcluser
sudo passwd lcluser
su - lcluser
sudo -l
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/544/head:pr544
git checkout pr544
URL: https://github.com/SSSD/sssd/pull/543
Author: jhrozek
Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1
Action: opened
PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/3684
If the cleanup task removes a user who was a fully resolved member (not a
ghost), but then the group the user was a member of is requested, unless
the group had changed, the user doesn't appear as a member of the group
again. This is because the modify timestamp would prevent the group from
updating and therefore the ghost attribute is not readded.
To mitigate this, let's also set the originalModifyTimestamp attribute to
1, so that we never take the optimized path while updating the group.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/543/head:pr543
git checkout pr543
URL: https://github.com/SSSD/sssd/pull/545
Author: fidencio
Title: #545: Two small fixes for KCM
Action: opened
PR body:
"""
Please, see each patch for a more complete description of each issue/fix.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/545/head:pr545
git checkout pr545