URL: https://github.com/SSSD/sssd/pull/734
Author: alexey-tikhonov
Title: #734: sss_client: minor fixes
Action: opened
PR body:
"""
A set of mostly cosmetic fixes with one notable exception:
fix of "mutex unlock without previous lock" bug in a couple of
nss_service functions.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/734/head:pr734
git checkout pr734
URL: https://github.com/SSSD/sssd/pull/732
Author: alexey-tikhonov
Title: #732: Issue 3841
Action: opened
PR body:
"""
sss_client/common.c: fix Coverity issue
Usage of strncpy(nssaddr.sun_path, socket_name, sizeof(nssaddr.sun_path))
1) confuses Coverity due to 3rd argument being equal to sizeof(1st)
2) again zeroes previously zeroed buffer
So replaced with strcpy()
This should be safe due to existing check of sizes.
Resolves: https://pagure.io/SSSD/sssd/issue/3841
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/732/head:pr732
git checkout pr732
URL: https://github.com/SSSD/sssd/pull/721
Author: jhrozek
Title: #721: AD/IPA: Reset subdomain service name, not domain name
Action: opened
PR body:
"""
Related: https://pagure.io/SSSD/sssd/issue/3911
Since commit 778f241e78241b0d6b8734148175f8dee804f494 the subdomain fail
over services use the "sd_" prefix. This was done to make it easier, until
the whole failover design works better with subdomains, to see which
services belong to the main domain from tools.
However, some parts of the code would still just use the domain name for
the failover service, which meant the service was not found, notably when
trying to reset services:
(Thu Dec 13 05:29:31 2018) [sssd[be[testrelm.test]]]
[ipa_srv_ad_acct_retried] (0x0400): Subdomain re-set, will retry lookup
(Thu Dec 13 05:29:31 2018) [sssd[be[testrelm.test]]] [be_fo_reset_svc]
(0x1000): Resetting all servers in service ipaad2016.test
(Thu Dec 13 05:29:31 2018) [sssd[be[testrelm.test]]] [be_fo_reset_svc]
(0x0080): Cannot retrieve service [ipaad2016.test]
This patch switches to reading the service names from the ad_options and
the sdap_service structures that are contained within ad_options.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/721/head:pr721
git checkout pr721
URL: https://github.com/SSSD/sssd/pull/735
Author: pbrezina
Title: #735: sbus: do not use signature when copying dictionary entry
Action: opened
PR body:
"""
When we open container for DBUS_TYPE_DICT_ENTRY, dbus expects the
signature to be NULL.
Reproducer:
1. Setup custom attributes
```
[ifp]
user_attributes = +test
[domain/ldap.vm]
...
ldap_user_extra_attrs = test:homeDirectory
```
2. Run SSSD and require those attributes for example with
```
sssctl user-checks user-1
```
3. SSSD will crash without the patch
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/735/head:pr735
git checkout pr735
URL: https://github.com/SSSD/sssd/pull/730
Title: #730: confdb: sssd tools don't handle the implicit domain
alexey-tikhonov commented:
"""
Looks good.
The only remark I have: may be it would make sense to mark `confdb_ensure_files_domain()` as `static` since it is not supposed to be used outside of module anymore.
"""
See the full comment at https://github.com/SSSD/sssd/pull/730#issuecomment-455246104
URL: https://github.com/SSSD/sssd/pull/703
Author: thalman
Title: #703: nss: sssd returns '/' for emtpy home directories
Action: opened
PR body:
"""
For empty home directory in passwd file sssd returns "/". Sssd
should respect system behaviour and return the same as nsswitch
"files" module - return empty string.
Resolves:
https://pagure.io/SSSD/sssd/issue/ To be defined
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/703/head:pr703
git checkout pr703