October 2019 - sssd-devel - Fedora mailing-lists

[sssd PR#909][opened] sssctl/sssctl_domains.c: null dereference fixed
by alexey-tikhonov 31 Oct '19

31 Oct '19

URL: https://github.com/SSSD/sssd/pull/909 Author: alexey-tikhonov Title: #909: sssctl/sssctl_domains.c: null dereference fixed Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4102 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/909/head:pr909 git checkout pr909

3 23

[sssd PR#913][opened] Updated test_pam_responder.py
by alexal 31 Oct '19

31 Oct '19

URL: https://github.com/SSSD/sssd/pull/913 Author: alexal Title: #913: Updated test_pam_responder.py Action: opened PR body: """ Integration tests/CI: Updated test_pam_responder.py and removed libnss3-dev from Debian dependency list - Functions create_nssdb_fixture and create_nssdb_no_cert_fixture inside test_pam_responder.py file will be called only if environment variable HAVE_NSS is defined - Since CI build for Debian is using OpenSSL this improvement allowed to drop libnss3-dev from Debian dependency list in contrib/ci/deps.sh Resolves: https://pagure.io/SSSD/sssd/issue/3914 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/913/head:pr913 git checkout pr913

5 42

[sssd PR#917][opened] sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno
by miztake 31 Oct '19

31 Oct '19

URL: https://github.com/SSSD/sssd/pull/917 Author: miztake Title: #917: sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno Action: opened PR body: """ sss_nss_timedloc() should return errno, but returns -1 if clock_gettime(2) fails. Fix sss_nss_timedlock() to return errno if clock_gettime(2) fails. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/917/head:pr917 git checkout pr917

4 10

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by scabrero 31 Oct '19

31 Oct '19

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. scabrero commented: """ Hi @sumit-bose, I fixed the PEP8 errors, the remaining CI failure seems unrelated to this PR. """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-548274238

1 0

[sssd PR#457][opened] ipa: Removal of umask(0) in selinux_child
by amitkumar50 30 Oct '19

30 Oct '19

URL: https://github.com/SSSD/sssd/pull/457 Author: amitkumar50 Title: #457: ipa: Removal of umask(0) in selinux_child Action: opened PR body: """ Code for calling umask(0) was added to address bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1186422. Now this bugzilla is fixed, removing the workaround. Resolves: https://pagure.io/SSSD/sssd/issue/3583 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/457/head:pr457 git checkout pr457

11 27

[sssd PR#908][opened] ifp: implement connection-wide access check
by pbrezina 29 Oct '19

29 Oct '19

URL: https://github.com/SSSD/sssd/pull/908 Author: pbrezina Title: #908: ifp: implement connection-wide access check Action: opened PR body: """ Currently only a small subset of infopipe methods performed access check. This change makes sure that we do this check global for everything. Steps to reproduce: 1. Call an infopipe method as a user not-listed in [ifp] allowed_uids 2. Without the patch the access is granted E.g. ``` $ dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users org.freedesktop.sssd.infopipe.Users.FindByName string:user-1 ``` Resolves: https://pagure.io/SSSD/sssd/issue/4105 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/908/head:pr908 git checkout pr908

2 6

New in the project & problem
by Iker Pedrosa 29 Oct '19

29 Oct '19

Hi team, I'm new to the project and I have been looking at the documentation that is available in pagure on how to start contributing to it. So far I have been able to configure, compile, install and launch the unit tests but I'm stuck with the integration tests. Whenever I execute the command to launch them (make intgcheck) I get the following error: You must have the header file http_parser.h installed to build sssd with secrets responder. If you want to build sssd without secret responder then specify --without-secrets when running configure. The problem is that I don't know if I should deactivate secrets responder. Which would be the impact if I disable it? I've been reading the man page and it states that this is a way of not exposing sensitive key material, but it's not clear for me if I would have this type of data in an integration test. Moreover, how do I apply this configuration? Am i right if I suppose that it should be applied when configuring the compilation (reconfig --without-secrets && chmake)?

2 2

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by sumit-bose 28 Oct '19

28 Oct '19

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. sumit-bose commented: """ Hi @scabrero, thank you very much for this substantial contribution. May I asked you to fix the Python pep8 issues identified by the CI test so that the other CI tests can be run? For your convenience I add them here as well: ``` Start: Mon Oct 28 15:41:33 UTC 2019 + find . -path ./src/config -prune -o -name '*.py' -exec pep8 --ignore=E121,E123,E126,E226,E24,E704,W503,W504,W605,E722 '{}' + ./src/tests/intg/ds_openldap.py:278:80: E501 line too long (84 > 79 characters) ./src/tests/intg/test_resolver.py:37:1: E265 block comment should start with '# ' ./src/tests/intg/test_resolver.py:41:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/test_resolver.py:77:80: E501 line too long (84 > 79 characters) ./src/tests/intg/test_resolver.py:208:32: E251 unexpected spaces around keyword / parameter equals ./src/tests/intg/test_resolver.py:208:34: E251 unexpected spaces around keyword / parameter equals ./src/tests/intg/test_resolver.py:213:32: E251 unexpected spaces around keyword / parameter equals ./src/tests/intg/test_resolver.py:213:34: E251 unexpected spaces around keyword / parameter equals ./src/tests/intg/sssd_hosts.py:31:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/sssd_hosts.py:38:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/sssd_nss.py:32:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/sssd_nss.py:51:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/sssd_nss.py:60:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/sssd_nss.py:70:1: E302 expected 2 blank lines, found 1 ./src/tests/intg/ldap_ent.py:150:26: E201 whitespace after '(' ./src/tests/intg/ldap_ent.py:150:57: E202 whitespace before ')' End: Mon Oct 28 15:41:36 UTC 2019 ``` bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-547020549

1 0

[sssd PR#918][comment] Add support for NSS hosts database lookup.
by centos-ci 28 Oct '19

28 Oct '19

URL: https://github.com/SSSD/sssd/pull/918 Title: #918: Add support for NSS hosts database lookup. centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-547004870

1 0

[sssd PR#854][opened] LDAP: Do not require START_TLS for loopback connections
by scabrero 28 Oct '19

28 Oct '19

URL: https://github.com/SSSD/sssd/pull/854 Author: scabrero Title: #854: LDAP: Do not require START_TLS for loopback connections Action: opened PR body: """ If the ldap uri is resolved to a loopback address then do not require START_TLS. Signed-off-by: Samuel Cabrero <scabrero(a)suse.de> """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/854/head:pr854 git checkout pr854

5 10

[sssd PR#907][opened] Update README.md
by alexal 23 Oct '19

23 Oct '19

URL: https://github.com/SSSD/sssd/pull/907 Author: alexal Title: #907: Update README.md Action: opened PR body: """ A few changes in README.md file: 1. Google+ is no longer available for consumer (personal) and brand accounts. I've removed the link to Google+ page as that link is no longer available. 2. I've added a link to a COPYING file. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/907/head:pr907 git checkout pr907

5 18

[sssd PR#910][opened] Added PRINT macro in the sssctl tool
by alexal 23 Oct '19

23 Oct '19

URL: https://github.com/SSSD/sssd/pull/910 Author: alexal Title: #910: Added PRINT macro in the sssctl tool Action: opened PR body: """ sssctl: Added PRINT macro in the sssctl tool As a continuation of PR #902 I've added a few more PRINT macros to the sssctl tool. Resolves: https://pagure.io/SSSD/sssd/issue/3078 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/910/head:pr910 git checkout pr910

5 13

[sssd PR#390][opened] NSS: Add option to disable memcache
by mzidek-rh 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/390 Author: mzidek-rh Title: #390: NSS: Add option to disable memcache Action: opened PR body: """ Added option use_memcache to centrally disable memcache for all clients without the need to specify SSS_NSS_USE_MEMCACHE=NO environment variable. Resolves: https://pagure.io/SSSD/sssd/issue/3496 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/390/head:pr390 git checkout pr390

8 106

[sssd PR#851][opened] Update __init__.py.in
by alexal 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/851 Author: alexal Title: #851: Update __init__.py.in Action: opened PR body: """ COMPONENT: SSSDConfig The default value for sudo_provider, auth_provider, and autofs_provider will be the value of id_provider, if those options weren't set in the configuration file Resolves: https://pagure.io/SSSD/sssd/issue/3995 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/851/head:pr851 git checkout pr851

6 60

[sssd PR#883][opened] Minor fixes to util/sss_krb5
by alexey-tikhonov 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/883 Author: alexey-tikhonov Title: #883: Minor fixes to util/sss_krb5 Action: opened PR body: """ Main purpose of this patches is to resolve: https://pagure.io/SSSD/sssd/issue/4081 It also fixes one coverity issue: ``` Error: DEADCODE (CWE-561): sssd-2.2.3/src/util/sss_krb5.c:375: cond_const: Condition "(kt_err = krb5_kt_next_entry(ctx, keytab, &entry, &cursor)) == 0", taking true branch. Now the value of "kt_err" is equal to 0. sssd-2.2.3/src/util/sss_krb5.c:406: const: At condition "kt_err != 0", the value of "kt_err" must be equal to 0. sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_condition: The condition "kt_err != 0" cannot be true. sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_line: Execution cannot reach the expression "kt_err != -1765328202L" inside this statement: "if (kt_err != 0 && kt_err !...". # 404| # 405| /* check if we got any errors from krb5_kt_next_entry */ # 406|-> if (kt_err != 0 && kt_err != KRB5_KT_END) { # 407| DEBUG(SSSDBG_CRIT_FAILURE, "Error while reading keytab.\n"); # 408| goto done; ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/883/head:pr883 git checkout pr883

4 44

[sssd PR#899][opened] sss_ptr_hash: pass new hash_entry_t to custom delete callback
by pbrezina 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/899 Author: pbrezina Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback Action: opened PR body: """ Setting `item->ptr = ptr` actually overwrote the original hash entry stored in the hash. If this entry is looked up in the delete callback it contains the overwritten value instead of the original. Steps to reproduce: ``` 1. Run sssd 2. Call e.g. `id user-1` 3. Terminate SSSD ``` You will see these `Invalid data type` messages. (Snippet from domain log) ``` [dp_client_destructor] (0x0400): Removed IFP client [sbus_signal_handler] (0x2000): Received D-Bus signal org.freedesktop.DBus.NameOwnerChanged on /org/freedesktop/DBus [sbus_signal_handler] (0x2000): Received D-Bus signal org.freedesktop.DBus.NameOwnerChanged on /org/freedesktop/DBus [sbus_senders_delete] (0x2000): Removing identity of sender [sssd.ifp] [sbus_issue_request_done] (0x0400): org.freedesktop.DBus.NameOwnerChanged: Success [sbus_senders_delete] (0x2000): Removing identity of sender [:1.5] [sbus_issue_request_done] (0x0400): org.freedesktop.DBus.NameOwnerChanged: Success [sbus_dispatch_reconnect] (0x0400): Connection lost. Terminating active requests. [sss_ptr_hash_check_type] (0x0020): Invalid data type detected. Expected [struct sss_ptr_hash_value], got [struct sbus_connection]. [sss_ptr_hash_check_type] (0x0020): Invalid data type detected. Expected [struct sss_ptr_hash_value], got [struct sbus_connection]. ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/899/head:pr899 git checkout pr899

2 18

[sssd PR#903][opened] Gpo man page updates
by mzidek-rh 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/903 Author: mzidek-rh Title: #903: Gpo man page updates Action: opened PR body: """ Hi, this PR contains two patches. One is from another PR (already acked by me and does not need a review, I just have it here to avoid conflicts and want to finally push it. It is from our probably oldest PR, that is still not merged https://pagure.io/SSSD/sssd/pull-request/3320) I will try to merge the patches from that PR together with some other GPO patches, but this PR is just about the man page changes. The second patch adds a note to the man page that current version of GPO does not support built-in groups in AD. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/903/head:pr903 git checkout pr903

3 11

[sssd PR#904][opened] KCM: Set kdc_offset to zero initially
by jhrozek 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/904 Author: jhrozek Title: #904: KCM: Set kdc_offset to zero initially Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4100 KCM assumed that the client library would always set the KDC offset, but that's not always the case, especially when using multiple krb contexts from the client application: https://bugzilla.redhat.com/show_bug.cgi?id=1757224#c64 Heimdal also creates ccaches with zero kdc_offset: https://github.com/heimdal/heimdal/commit/9f58896af958ae5e6e3ebde8c48dad4ed… so we should do the same.. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/904/head:pr904 git checkout pr904

4 11

[sssd PR#906][opened] memcache: Stop using the word fastcache for memcache
by mzidek-rh 21 Oct '19

21 Oct '19

URL: https://github.com/SSSD/sssd/pull/906 Author: mzidek-rh Title: #906: memcache: Stop using the word fastcache for memcache Action: opened PR body: """ This patch removes the word fastche from our codebase. We do not reffer to the fast in-memory mmaped cache consistantly. Sometimes we call it fastcache, sometimes memcache and sometimes mmap cache. While we can not get rid of memcache, because it is rooted in some config option names and in the documentation and mmap cache is used a lot internally in our code, so getting rid of that would require a lot of code changes, we can easyly get rid of the 'fastcache' word because it is only in a handful of places. I think we should really stick to calling it memcache in the documentation and debug messages and ideally also in code comments to avoid confusion. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/906/head:pr906 git checkout pr906

3 16

[sssd PR#858][opened] ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
by pbrezina 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/858 Author: pbrezina Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true Action: opened PR body: """ This caused an error when saving local user as a fallback: ``` [sdap_save_user] (0x0400): Storing info for user testuser(a)ldap.vm [sysdb_ldb_msg_difference] (0x2000): Added attr [gecos] to entry [name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [Invalid attribute syntax](21)[Element gecos has empty attribute in ldb message (name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb) [sysdb_set_cache_entry_attr] (0x0040): Error: 22 (Invalid argument) [sysdb_set_entry_attr] (0x0080): Cannot set attrs for name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb, 22 [Invalid argument] [sysdb_store_user] (0x0040): Cache update failed: 22 [sysdb_store_user] (0x0400): Error: 22 (Invalid argument) [sdap_save_user] (0x0020): Failed to save user [testuser(a)ldap.vm] ``` Steps to reproduce: 1. create local user `testuser` 2. add it to LDAP group memberUid 3. set `passwd: sss files`, `group: sss files` (sss must be before files) 4. set enable_files_domain = false and ldap_rfc2307_fallback_to_local_users = true 5. run sssd 6. id testuser -> it does not contain the LDAP group without the patch Resolves: https://pagure.io/SSSD/sssd/issue/4013 Note: this fix only the case when the nsswitch order is `sss files` but no files domain is available. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/858/head:pr858 git checkout pr858

2 14

[sssd PR#864][opened] Monitor resolv.conf symlink
by scabrero 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/864 Author: scabrero Title: #864: Monitor resolv.conf symlink Action: opened PR body: """ If resolv.conf is a symlink and sssd starts before getting an address from dhcp the data provider will remain forever offline, as the watched parent directory is the directory containing the symlink. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/864/head:pr864 git checkout pr864

4 18

[sssd PR#898][opened] util/server: amended close_low_fds()
by alexey-tikhonov 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/898 Author: alexey-tikhonov Title: #898: util/server: amended close_low_fds() Action: opened PR body: """ Rewrote close_low_fds() to use freopen() as it fits better here and some flags passed to open() previously didn't make a sense. Also fixed a number of identical Coverity issues: ``` Error: RESOURCE_LEAK (CWE-772): sssd-2.2.3/src/util/server.c:58: open_fn: Returning handle opened by "open". [Note: The source code implementation of the function has been overridden by a user model.] sssd-2.2.3/src/util/server.c:58: var_assign: Assigning: "fd" = handle returned from "open("/dev/null", 1, 0)". sssd-2.2.3/src/util/server.c:56: overwrite_var: Overwriting handle "fd" in "fd = open("/dev/null", 2, 0)" leaks the handle. 54| library routines writing to stdout etc. won't cause havoc */ 55| for (i = 0; i < 3; i++) { 56|-> fd = open("/dev/null", O_RDWR, 0); 57| if (fd < 0) 58| fd = open("/dev/null", O_WRONLY, 0); ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/898/head:pr898 git checkout pr898

3 10

[sssd PR#900][opened] SSS_CLIENT: got rid of using PRNG
by alexey-tikhonov 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/900 Author: alexey-tikhonov Title: #900: SSS_CLIENT: got rid of using PRNG Action: opened PR body: """ 1) no reason to expect "thundering herd issue" 2) randomization as it was done (strictly 1 or 2 secs) would not help much anyway 3) usage of PRNG might break app that depends on deterministic PRNG behaviour Resolves: https://pagure.io/SSSD/sssd/issue/4094 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/900/head:pr900 git checkout pr900

3 10

[sssd PR#901][opened] Update sss_ssh.c
by alexal 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/901 Author: alexal Title: #901: Update sss_ssh.c Action: opened PR body: """ SSH: Adds a message to the syslog if an SSH key is malformed If an SSH key contains trailing whitespace (or newlines), it will be considered as malformed by sss_ssh_format_pubkey() function. With the current version the only way to detect that problem is to enable --debug option for /usr/bin/sss_ssh_authorizedkeys utility. I'm adding an additional message to the syslog which will help to determine such problems without enabling debug. Resolves: https://pagure.io/SSSD/sssd/issue/3864 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/901/head:pr901 git checkout pr901

5 12

[sssd PR#902][opened] Added ERROR and PRINT macros to the tools
by alexal 17 Oct '19

17 Oct '19

URL: https://github.com/SSSD/sssd/pull/902 Author: alexal Title: #902: Added ERROR and PRINT macros to the tools Action: opened PR body: """ Tools: Added ERROR and PRINT macros to the tools Replaced functions printf and fprintf with corresponding PRINT and ERROR macro in the tools. Resolves: https://pagure.io/SSSD/sssd/issue/3078 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/902/head:pr902 git checkout pr902

5 24

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel October 2019