July 2019 - sssd-devel - Fedora Mailing-Lists

[sssd PR#848][opened] crypto/nss: some nss_ctx_init() params made const

by alexey-tikhonov

URL: https://github.com/SSSD/sssd/pull/848 Author: alexey-tikhonov Title: #848: crypto/nss: some nss_ctx_init() params made const Action: opened PR body: """ This patch fixes compilation issues introduced in 8aa0dfd : as `key` parameter of sss_encrypt() and sss_decrypt() became const, changes in signature of nss_ctx_init() were required to follow up. For more details see SSSD#846 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/848/head:pr848 git checkout pr848

4 years, 9 months

3
7
0 / 0

[sssd PR#838][opened] FIPS140 compliant usage of PRNG

by alexey-tikhonov

URL: https://github.com/SSSD/sssd/pull/838 Author: alexey-tikhonov Title: #838: FIPS140 compliant usage of PRNG Action: opened PR body: """ Resolves https://pagure.io/SSSD/sssd/issue/4024 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/838/head:pr838 git checkout pr838

4 years, 9 months

5
28
0 / 0

[sssd PR#846][opened] crypto: unconst key in sss_encrypt and sss_decrypt

by pbrezina

URL: https://github.com/SSSD/sssd/pull/846 Author: pbrezina Title: #846: crypto: unconst key in sss_encrypt and sss_decrypt Action: opened PR body: """ The key parameter was made const in 8aa0dfdf6e36fa90855c0f35a4dfa57139ad6504 but it produces errors: ``` CC src/util/crypto/libsss_crypt_la-sss_crypto.lo /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c: In function ‘sss_encrypt’: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:96:38: error: passing argument 3 of ‘nss_ctx_init’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] ret = nss_ctx_init(tmp_ctx, enc, key, keylen, out, ivlen, &cctx); ^~~ In file included from /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:30: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_crypto.h:61:27: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘const uint8_t *’ {aka ‘const unsigned char *’} uint8_t *key, int keylen, ~~~~~~~~~^~~ /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:133:39: error: passing argument 3 of ‘nss_ctx_init’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] ret = nss_ctx_init(tmp_ctx, hmac, key, keylen, NULL, 0, &hctx); ^~~ In file included from /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:30: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_crypto.h:61:27: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘const uint8_t *’ {aka ‘const unsigned char *’} uint8_t *key, int keylen, ~~~~~~~~~^~~ /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c: In function ‘sss_decrypt’: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:221:39: error: passing argument 3 of ‘nss_ctx_init’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] ret = nss_ctx_init(tmp_ctx, hmac, key, keylen, NULL, 0, &hctx); ^~~ In file included from /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:30: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_crypto.h:61:27: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘const uint8_t *’ {aka ‘const unsigned char *’} uint8_t *key, int keylen, ~~~~~~~~~^~~ /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:268:38: error: passing argument 3 of ‘nss_ctx_init’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] ret = nss_ctx_init(tmp_ctx, enc, key, keylen, ivbuf, ivlen, &cctx); ^~~ In file included from /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_nite.c:30: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_crypto.h:61:27: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘const uint8_t *’ {aka ‘const unsigned char *’} uint8_t *key, int keylen, ``` Making the parameter const also in `nss_ctx_init` will produce another error which is out of our control thus removing the const. ``` In file included from /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_util.c:33: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_util.c: In function ‘nss_ctx_init’: /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_crypto.h:33:19: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] (sitem)->data = (sdata); \ ^ /home/pbrezina/workspace/sssd/src/util/crypto/nss/nss_util.c:180:13: note: in expansion of macro ‘MAKE_SECITEM’ MAKE_SECITEM(key, keylen, cctx->key); ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/846/head:pr846 git checkout pr846

4 years, 9 months

2
8
0 / 0

[sssd PR#812][opened] Implement background refresh for IPA and AD domains and subdomains

by jhrozek

URL: https://github.com/SSSD/sssd/pull/812 Author: jhrozek Title: #812: Implement background refresh for IPA and AD domains and subdomains Action: opened PR body: """ This PR refactors the existing background refresh task to be more extendable, splits out the account handlers of IPA and AD providers into tevent requests which are finally reused by new ipa_refresh and ad_refresh modules. The refreshes are done in batches so that we don't starve out other requests or even invoke the watchdog. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/812/head:pr812 git checkout pr812

4 years, 9 months

2
40
0 / 0

[sssd PR#835][opened] LDAP: failover does not work on non-responsive ldaps

by thalman

URL: https://github.com/SSSD/sssd/pull/835 Author: thalman Title: #835: LDAP: failover does not work on non-responsive ldaps Action: opened PR body: """ In case ldaps:// is used, then establishing the secure socket is a sychronous operation. If there's nothing on the other end, then the process would be stuck waiting in for the crypto library to finish. Here we set socket read/write timeout so the operation can finish in reasonable time with an error. The ldap_network_timeout option is used for this timeout. Resolves: https://pagure.io/SSSD/sssd/issue/2878 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/835/head:pr835 git checkout pr835

4 years, 9 months

3
7
0 / 0

[sssd PR#708][opened] TESTS: ldb-tools are required for multihost tests

by mzidek-rh

URL: https://github.com/SSSD/sssd/pull/708 Author: mzidek-rh Title: #708: TESTS: ldb-tools are required for multihost tests Action: opened PR body: """ Some of the test do use ldbsearch. Resolves: https://pagure.io/SSSD/sssd/issue/3894 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/708/head:pr708 git checkout pr708

4 years, 9 months

2
11
0 / 0

[sssd PR#839][opened] util/find_uid.c: fixed race condition bug

by alexey-tikhonov

URL: https://github.com/SSSD/sssd/pull/839 Author: alexey-tikhonov Title: #839: util/find_uid.c: fixed race condition bug Action: opened PR body: """ It was wrong to return EOK from get_uid_from_pid() in case of failed open() or fstat() as this leaves `uid` uninitialized and no means for caller to detect this situation. There was no reason to fail get_active_uid_linux() completely in case of failed get_uid_from_pid() for one of /proc entries. Function was changed to continue with next entry instead. Resolves: https://pagure.io/SSSD/sssd/issue/2854 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/839/head:pr839 git checkout pr839

4 years, 9 months

2
9
0 / 0

[sssd PR#716][opened] CACHE: SSSD doesn't clear cache entries

by thalman

URL: https://github.com/SSSD/sssd/pull/716 Author: thalman Title: #716: CACHE: SSSD doesn't clear cache entries Action: opened PR body: """ Once object is in cache it is refreshed when it is expired and requested by the system. Object ID is not checked before refresh, but config parameter ldap_(min|max)_id could be changed by admin. We should check object ID and not refresh objects outside min/max ID interval. Resolves: https://pagure.io/SSSD/sssd/issue/3905 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/716/head:pr716 git checkout pr716

4 years, 9 months

4
14
0 / 0

[sssd PR#840][opened] util/secrets: memory leaks are fixed

by alexey-tikhonov

URL: https://github.com/SSSD/sssd/pull/840 Author: alexey-tikhonov Title: #840: util/secrets: memory leaks are fixed Action: opened PR body: """ Fixed a couple of non critical memory leaks. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/840/head:pr840 git checkout pr840

4 years, 9 months

2
5
0 / 0

[sssd PR#842][opened] crypto/libcrypto/crypto_nite: HMAC calculation changed

by alexey-tikhonov

URL: https://github.com/SSSD/sssd/pull/842 Author: alexey-tikhonov Title: #842: crypto/libcrypto/crypto_nite: HMAC calculation changed Action: opened PR body: """ Changed HMAC calculation to make it consistent with https://pagure.io/SSSD/sssd/issue/4026 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/842/head:pr842 git checkout pr842

4 years, 9 months

2
4
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel July 2019