[sssd PR#558][opened] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache
by jhrozek
URL: https://github.com/SSSD/sssd/pull/558
Author: jhrozek
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache
Action: opened
PR body:
"""
This is a WIP on adding tests for the sss_nss_ex interface. I covered only the sss_nss_getgrouplist_timeout function so far.
I'm submitting the PR already in this state to get some feedback if this
coverage is enough and the other functions can be covered similarly or
if there is some issue with this approach.
Also, I found a bug in invalidating the initgroups memory cache, that's
the first of the two patches. Here I'm really not sure if the fix is even
how the issue should be fixed, so I just hacked something up, even without
allocation checks etc.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/558/head:pr558
git checkout pr558
4 years, 5 months
[sssd PR#883][opened] Minor fixes to util/sss_krb5
by alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/883
Author: alexey-tikhonov
Title: #883: Minor fixes to util/sss_krb5
Action: opened
PR body:
"""
Main purpose of this patches is to resolve: https://pagure.io/SSSD/sssd/issue/4081
It also fixes one coverity issue:
```
Error: DEADCODE (CWE-561):
sssd-2.2.3/src/util/sss_krb5.c:375: cond_const: Condition "(kt_err = krb5_kt_next_entry(ctx, keytab, &entry, &cursor)) == 0", taking true branch. Now the value of "kt_err" is equal to 0.
sssd-2.2.3/src/util/sss_krb5.c:406: const: At condition "kt_err != 0", the value of "kt_err" must be equal to 0.
sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_condition: The condition "kt_err != 0" cannot be true.
sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_line: Execution cannot reach the expression "kt_err != -1765328202L" inside this statement: "if (kt_err != 0 && kt_err !...".
# 404|
# 405| /* check if we got any errors from krb5_kt_next_entry */
# 406|-> if (kt_err != 0 && kt_err != KRB5_KT_END) {
# 407| DEBUG(SSSDBG_CRIT_FAILURE, "Error while reading keytab.\n");
# 408| goto done;
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/883/head:pr883
git checkout pr883
4 years, 6 months
[sssd PR#858][opened] ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
by pbrezina
URL: https://github.com/SSSD/sssd/pull/858
Author: pbrezina
Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Action: opened
PR body:
"""
This caused an error when saving local user as a fallback:
```
[sdap_save_user] (0x0400): Storing info for user testuser(a)ldap.vm
[sysdb_ldb_msg_difference] (0x2000): Added attr [gecos] to entry [name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb]
[sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [Invalid attribute syntax](21)[Element gecos has empty attribute in ldb message (name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb)!]
[sysdb_set_cache_entry_attr] (0x0040): Error: 22 (Invalid argument)
[sysdb_set_entry_attr] (0x0080): Cannot set attrs for name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb, 22 [Invalid argument]
[sysdb_store_user] (0x0040): Cache update failed: 22
[sysdb_store_user] (0x0400): Error: 22 (Invalid argument)
[sdap_save_user] (0x0020): Failed to save user [testuser(a)ldap.vm]
```
Steps to reproduce:
1. create local user `testuser`
2. add it to LDAP group memberUid
3. set `passwd: sss files`, `group: sss files` (sss must be before files)
4. set enable_files_domain = false and ldap_rfc2307_fallback_to_local_users = true
5. run sssd
6. id testuser
-> it does not contain the LDAP group without the patch
Resolves:
https://pagure.io/SSSD/sssd/issue/4013
Note: this fix only the case when the nsswitch order is `sss files` but no files domain is available.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/858/head:pr858
git checkout pr858
4 years, 6 months