sssd-devel July 2020

sssd-devel@lists.fedorahosted.org

3 participants
91 discussions

Start a nNew thread

[sssd PR#5228][-Changes requested] Test: Add back removed tests
by elkoniu 21 Jul '20

21 Jul '20

URL: https://github.com/SSSD/sssd/pull/5228 Title: #5228: Test: Add back removed tests Label: -Changes requested

1 0

[sssd PR#5228][comment] Test: Add back removed tests
by ikerexxe 21 Jul '20

21 Jul '20

URL: https://github.com/SSSD/sssd/pull/5228 Title: #5228: Test: Add back removed tests ikerexxe commented: """ test_users_by_filter_valid() was restored in [da79bee](https://github.com/SSSD/sssd/commit/da79bee1472a06b89be2df903fb0bd… and in [a6a5a08](https://github.com/SSSD/sssd/commit/a6a5a08a357d2adbb653b81bacc602…. While test_groups_by_filter_valid() was restored in [fe6dd66](https://github.com/SSSD/sssd/commit/fe6dd669d1e8606862879127f92c17… and in [16212bb](https://github.com/SSSD/sssd/commit/16212bbb2aaa55d0587515e72c0018…. That's why [issue 3920](https://github.com/SSSD/sssd/issues/3920) only mentions test_users_by_filter_multiple_domains_valid() and test_groups_by_filter_multiple_domains_valid(). """ See the full comment at https://github.com/SSSD/sssd/pull/5228#issuecomment-661704836

1 0

[sssd PR#5228][comment] Test: Add back removed tests
by elkoniu 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5228 Title: #5228: Test: Add back removed tests elkoniu commented: """ Mentioned commit (bdf422f) removed in total 4 tests: test_users_by_filter_valid() test_users_by_filter_multiple_domains_valid() test_groups_by_filter_valid() test_groups_by_filter_multiple_domains_valid() Your PR restored 2 of 4 removed tests. What with other two? They are unrelated / deprecated or material for other PR? Or if it is worth to restore them too as they were removed together? """ See the full comment at https://github.com/SSSD/sssd/pull/5228#issuecomment-661355096

1 0

[sssd PR#5228][comment] Test: Add back removed tests
by ikerexxe 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5228 Title: #5228: Test: Add back removed tests ikerexxe commented: """ > LGTM, but 2 things: > > 1. Add info about original reason of removing those tests and link to commit / PR which removes them. > Just to keep some track of history here. > 2. Those tests were fixed by you so you can add some info in this thread what was wrong with the original ones. > 3. Commit [7652873](https://github.com/SSSD/sssd/commit/76528734f9ad0a518bfa7c94d9b403… is from some reason failing on upstream CI test. If it is false positive? 1 and 2 are done. I was waiting for the CI to complete but it's taking a lot of time so I'm not completely sure about 3. Anyways, I think the problem is not related with the test itself. """ See the full comment at https://github.com/SSSD/sssd/pull/5228#issuecomment-660981660

1 0

[sssd PR#5243][-Waiting for review] responder/common/responder_packet: get packet length only once
by pbrezina 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5243 Title: #5243: responder/common/responder_packet: get packet length only once Label: -Waiting for review

1 0

[sssd PR#5243][+Accepted] responder/common/responder_packet: get packet length only once
by pbrezina 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5243 Title: #5243: responder/common/responder_packet: get packet length only once Label: +Accepted

1 0

[sssd PR#5243][comment] responder/common/responder_packet: get packet length only once
by pbrezina 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5243 Title: #5243: responder/common/responder_packet: get packet length only once pbrezina commented: """ LGTM. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5243#issuecomment-660925353

1 0

[sssd PR#5228][synchronized] Test: Add back removed tests
by ikerexxe 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5228 Author: ikerexxe Title: #5228: Test: Add back removed tests Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5228/head:pr5228 git checkout pr5228

1 0

[sssd PR#5237][closed] sss_ssh_knownhostsproxy: print error when unable to connect
by pbrezina 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5237 Author: pbrezina Title: #5237: sss_ssh_knownhostsproxy: print error when unable to connect Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5237/head:pr5237 git checkout pr5237

1 0

[sssd PR#5237][-Ready to push] sss_ssh_knownhostsproxy: print error when unable to connect
by pbrezina 20 Jul '20

20 Jul '20

URL: https://github.com/SSSD/sssd/pull/5237 Title: #5237: sss_ssh_knownhostsproxy: print error when unable to connect Label: -Ready to push

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel July 2020