URL: https://github.com/SSSD/sssd/pull/5223
Title: #5223: [wip] Add .clang-format
pbrezina commented:
"""
I pushed little update. So far it works great for development. But it has some issues when trying to automatically correct the coding style in some scenarios. It tries to change more code then it is supposed to when git diff creates bigger snippet then a small change self-contained change.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5223#issuecomment-660077063
URL: https://github.com/SSSD/sssd/pull/5228
Author: ikerexxe
Title: #5228: Test: Add back removed tests
Action: edited
Changed field: body
Original value:
"""
Tests: ```users_by_filter_multiple_domains_valid``` and ```groups_by_filter_multiple_domains_valid``` were removed in the past and these commits add them back.
```users_by_filter_multiple_domains_valid``` test explanation:
Given two users are present
When the users are searched by filtering domains
Then the two users are returned correctly.
```groups_by_filter_multiple_domains_valid``` test explanation:
Given two groups are present
When the groups are searched by filtering domains
Then the two groups are returned correctly.
Resolves: https://github.com/SSSD/sssd/issues/3920
"""
URL: https://github.com/SSSD/sssd/pull/1036
Title: #1036: certmap: sanitize LDAP search filter
jsf9k commented:
"""
I am running into this same issue, also having to do with parentheses in CNs when dealing with U.S. government smart cards. I'm going to have to configure FreeIPA to match on full certificates for now and revert back to using certmap data once this PR is merged.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1036#issuecomment-659416781
URL: https://github.com/SSSD/sssd/pull/5246
Title: #5246: (WiP) Drop support of libnss as a crypto backend
alexey-tikhonov commented:
"""
PR is marked as "WiP" because I plan to add another patch to rename misleading `--nssdb` arg of `p11_child`.
Still I posted it so that anyone interested could have a preliminary look.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5246#issuecomment-658908989
URL: https://github.com/SSSD/sssd/pull/5213
Title: #5213: config: [RFE] Add "enabled" option to domain section
alexey-tikhonov commented:
"""
> Pushed PR: #5213
>
> * `master`
>
> * [ff8d7b8](https://github.com/SSSD/sssd/commit/ff8d7b8f0dca57d04ed4157bc60ad3… - config: [RFE] Add "enabled" option to domain section
This patch introduced following compilation warning:
```
../src/confdb/confdb.c: In function ‘confdb_get_domains’:
../src/confdb/confdb.c:2499:12: warning: ‘enabled’ may be used uninitialized in this function [-Wmaybe-uninitialized]
2499 | if (enabled && !string_in_list(all_domains[idx], domlist, false)) {
| ^
../src/confdb/confdb.c:2460:10: note: ‘enabled’ was declared here
2460 | bool enabled;
| ^~~~~~~
```
This is clearly false positive, but still would be good to fix.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5213#issuecomment-658725445