URL: https://github.com/SSSD/sssd/pull/5231
Title: #5231: libwbclient-sssd: deprecate libwbclient-sssd
alexey-tikhonov commented:
"""
> Shouldn't we check the version of Samba and based on it include / exclude this in build?
IIUC, Samba requires running winbindd few years already.
Even if somebody will build recent SSSD in an env with very old Samba, it's still possible to configure libwbclient build explicitly.
Taking into account we plan to remove its code completely in upcoming versions, I don't think it's worth the effort to automatically try to guess if libwbclient is required.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5231#issuecomment-662917388
URL: https://github.com/SSSD/sssd/pull/1036
Title: #1036: certmap: sanitize LDAP search filter
alexey-tikhonov commented:
"""
Hi,
patch looks good to me.
Besides few cosmetic comments (see inline) I would only propose to extend `test_certmap.c` with a case where "()" are really used in a certificate (but perhaps this is not needed because `util-tests.c::test_sss_filter_sanitize` covers this...)
Covscan is clean.
But unfortunately I don't have environment at hand to actually test this patch.
Perhaps @spoore1 will be able to test this (scratch build provided).
"""
See the full comment at https://github.com/SSSD/sssd/pull/1036#issuecomment-662610790
URL: https://github.com/SSSD/sssd/pull/5246
Author: alexey-tikhonov
Title: #5246: Drop support of libnss as a crypto backend
Action: edited
Changed field: title
Original value:
"""
(WiP) Drop support of libnss as a crypto backend
"""