August 2020 - sssd-devel - Fedora mailing-lists

[sssd PR#175][opened] Add module for starting services
by lslebodn 22 Nov '21

22 Nov '21

URL: https://github.com/SSSD/sssd/pull/175 Author: lslebodn Title: #175: Add module for starting services Action: opened PR body: """ This is a WIP version of reducing code duplication in our cwrap integration tests. I am still not sure whether we should also reuse function `create_sssd_fixture`. And if yes; then probably in different nodule then `services` And comments are welcome. BTW I wrote patches few weeks ago; therefore new tests are not converted. I am just sending patches to get some feedback. Site effect of this patches is that tests are cca 20% faster (IIRC) """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/175/head:pr175 git checkout pr175

5 5

[sssd PR#844][opened] sssd-ad and gpo_child: GPO apply fixes during reading fails
by mastersin 03 Aug '21

03 Aug '21

URL: https://github.com/SSSD/sssd/pull/844 Author: mastersin Title: #844: sssd-ad and gpo_child: GPO apply fixes during reading fails Action: opened PR body: """ Ignore AD GPO errors: - if SecEdit/GptTmpl.inf is missing or - if reading sysvol_gpt_version fails and cached_gpt_version already exists """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/844/head:pr844 git checkout pr844

7 16

[sssd PR#5245][opened] RESOLV: Avoid DNS search to improve fail-over reaction
by thalman 16 Mar '21

16 Mar '21

URL: https://github.com/SSSD/sssd/pull/5245 Author: thalman Title: #5245: RESOLV: Avoid DNS search to improve fail-over reaction Action: opened PR body: """ In case of unreachable DNS server or invalid hostname sssd/c-ares tries to search in multiple domains based on the search directive in resolv.conf But the hostnames in config file are fully qualified and this just extends the time spent with DNS resolution. This patch set the c-ares library flags to avoid DNS search Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1608496 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5245/head:pr5245 git checkout pr5245

5 31

[sssd PR#5264][opened] Utils: White space replace with another character
by elkoniu 08 Feb '21

08 Feb '21

URL: https://github.com/SSSD/sssd/pull/5264 Author: elkoniu Title: #5264: Utils: White space replace with another character Action: opened PR body: """ Function responsible for replacing white space has wrong log levels set. It can create false positive critical error messages broadcasted across the system without any real reason. This patch adjusts those log levels to be on the debug level rather than criticar error level. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1818671 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5264/head:pr5264 git checkout pr5264

3 7

[sssd PR#5268][opened] proxy_child hardening
by alexey-tikhonov 29 Jan '21

29 Jan '21

URL: https://github.com/SSSD/sssd/pull/5268 Author: alexey-tikhonov Title: #5268: proxy_child hardening Action: opened PR body: """ Fixes #3730 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5268/head:pr5268 git checkout pr5268

4 32

[sssd PR#616][opened] become_user: add supplementary groups so ad provider can access keytab
by asheplyakov 28 Jan '21

28 Jan '21

URL: https://github.com/SSSD/sssd/pull/616 Author: asheplyakov Title: #616: become_user: add supplementary groups so ad provider can access keytab Action: opened PR body: """ For security reasons one might want to run providers as a non-privileged user (say, _sssd). However some providers (in particular ad) might need an access to restricted (non world-readable) files (for instance, /etc/krb5.keytab). One of the possible ways to solve the problem is to - add a special group (for instance, _keytab) - set the owner:group of the file in question to root:_keytab - set the permissions of the file in question to 640 - make the _sssd user a member of the _keytab group For this to work become_user should assign supplementary groups, which is what this patch does. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/616/head:pr616 git checkout pr616

5 13

[sssd PR#5251][opened] [wip] subdomains: allow to inherit case_sensitive=Preserving
by pbrezina 26 Jan '21

26 Jan '21

URL: https://github.com/SSSD/sssd/pull/5251 Author: pbrezina Title: #5251: [wip] subdomains: allow to inherit case_sensitive=Preserving Action: opened PR body: """ The first patch is just man page update to reflect current state. I think it makes sense to be able to show subdomain names in their original casing. Patches 2-3 make it work for AD provider. Patch 4 makes it work for IPA provider. There is apparantely a bug in winbind, but there is no link the any bugzilla so I do not know if it was already fixed. The commit is four years old. This patch requires case_sensitive=Preserving to be set also on the server, otherwise it does not work. It can be enabled without the server setting but we need to make nss_cmd_getpwnam_ex (and other _ex commands) to always return case preserving name. So before I continue the work I'd like to ask @sumit-bose if we can do it like this. Resolves: https://github.com/SSSD/sssd/issues/5250 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5251/head:pr5251 git checkout pr5251

3 28

[sssd PR#5300][opened] ad: use parallel cldap ping for site discovery
by pbrezina 23 Oct '20

23 Oct '20

URL: https://github.com/SSSD/sssd/pull/5300 Author: pbrezina Title: #5300: ad: use parallel cldap ping for site discovery Action: opened PR body: """ This PR adds support for CLDAP (connectionless LDAP over UDP) and makes use of it during site discovery. The discovery process is improved, it now sends the CLDAP ping to all discovered domain controllers at once to avoid potential timeouts when some of them are unreachable (which is quite common in real environment). The first received reply is used. The netlogon information is now requested only when SSSD starts and when we are recovering from offline state To avoid swamping network with many ping. This is quite fine given the site and forest information is not dynamic but usually stable. Additional improvement is that if we already know client's site we ping only in-site controllers first. We were already doing that but now we also fallback to off-site controllers in case none in-site controller is unreachable. Previously we would just fail. There is a bug in openldap [1] that makes SSSD wait for timeout in-case none of the controller is reachable, but as long as at least one is reachble the resolution will be fast. Resolves: https://github.com/SSSD/sssd/issues/3743 https://github.com/SSSD/sssd/issues/5215 [1] https://bugs.openldap.org/show_bug.cgi?id=9328 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5300/head:pr5300 git checkout pr5300

4 25

[sssd PR#5269][opened] Translations update from Weblate
by weblate 12 Oct '20

12 Oct '20

URL: https://github.com/SSSD/sssd/pull/5269 Author: weblate Title: #5269: Translations update from Weblate Action: opened PR body: """ Translations update from [Weblate](https://translate.fedoraproject.org/projects/sssd/sssd-1-16/) for SSSD/sssd-1-16. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5269/head:pr5269 git checkout pr5269

3 5

[sssd PR#5286][opened] Translations update from Weblate
by weblate 12 Oct '20

12 Oct '20

URL: https://github.com/SSSD/sssd/pull/5286 Author: weblate Title: #5286: Translations update from Weblate Action: opened PR body: """ Translations update from [Weblate](https://translate.fedoraproject.org/projects/sssd/sssd-master/) for SSSD/sssd. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5286/head:pr5286 git checkout pr5286

2 5

[sssd PR#5257][opened] git-template: add tags to help with release notes automation
by pbrezina 12 Oct '20

12 Oct '20

URL: https://github.com/SSSD/sssd/pull/5257 Author: pbrezina Title: #5257: git-template: add tags to help with release notes automation Action: opened PR body: """ This commits add information on several tags that should be used so we are able to generate release notes on each new release automatically. This will make release notes more thorough and it will also simplify the process a lot since it take lots of time to do it manually. Why I chose `:tag:` format> 1. Using @ notation creates user references in github so I wanted to use something different. 2. Using a plain text like (Resolves) leads people to create their own variations (Fixes, Resolves XYZ, ...) which adds additional burden to maintainers. Using this format makes it less error prone and easier to parse. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5257/head:pr5257 git checkout pr5257

6 43

[sssd PR#5281][opened] Dn with spaces for 1.16
by thalman 06 Oct '20

06 Oct '20

URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: opened PR body: """ Cherry picked commits of PR https://github.com/SSSD/sssd/pull/5262 Resolves: #5261 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281

4 44

[sssd PR#5262][opened] Dn with spaces
by elkoniu 02 Oct '20

02 Oct '20

URL: https://github.com/SSSD/sssd/pull/5262 Author: elkoniu Title: #5262: Dn with spaces Action: opened PR body: """ This PR is push to upstream work of @thalman as he is on PTO now. Those 2 commits fixes issue with white space in DN reported by one of clients. Client already confirmed that this solves the issue for him. When @thalman will be back from PTO he will took over this. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5262/head:pr5262 git checkout pr5262

6 69

[sssd PR#943][opened] files_ops: Fix cached password remove
by elkoniu 01 Oct '20

01 Oct '20

URL: https://github.com/SSSD/sssd/pull/943 Author: elkoniu Title: #943: files_ops: Fix cached password remove Action: opened PR body: """ When SSSD daemon will detect refresh of password (group) file it will delete all cached users (groups) data. With this change cached data will be deleted only for non existing users (groups). Resolves: https://pagure.io/SSSD/sssd/issue/3591 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/943/head:pr943 git checkout pr943

3 16

[sssd PR#5272][opened] WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM
by ikerexxe 01 Oct '20

01 Oct '20

URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM Action: opened PR body: """ This is work in progress! There was a mismatch between the information provided by NSS and IFP interfaces. nss_protocol_fill_initgr() returned SYSDB_PRIMARY_GROUP_GIDNUM, but GetUserGroups() didn't. This commit makes GetUserGroups() also return SYSDB_PRIMARY_GROUP_GIDNUM value. Resolves: https://github.com/SSSD/sssd/issues/4569 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272

5 26

[sssd PR#5296][opened] AD: validate `search_bases` in DPM_ACCT_DOMAIN_HANDLER
by alexey-tikhonov 30 Sep '20

30 Sep '20

URL: https://github.com/SSSD/sssd/pull/5296 Author: alexey-tikhonov Title: #5296: AD: validate `search_bases` in DPM_ACCT_DOMAIN_HANDLER Action: opened PR body: """ In specific circumstances "sdom->*_search_bases" might be unset yet when "ad_get_account_domain_send() -> ad_get_account_domain_prepare_search()" is executed. Resolves: https://github.com/SSSD/sssd/issues/5295 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5296/head:pr5296 git checkout pr5296

3 15

[sssd PR#5297][opened] Fix IP network by address lookup
by scabrero 30 Sep '20

30 Sep '20

URL: https://github.com/SSSD/sssd/pull/5297 Author: scabrero Title: #5297: Fix IP network by address lookup Action: opened PR body: """ Resolves https://github.com/SSSD/sssd/issues/5256. The first commit fixes the error path when an IP host is not found in the proxy provider. A memory allocation error was logged because we didn't jump to done label after receiving ENOENT. ``` [be[test]] [proxy_save_host] (0x0040): Cannot get cased name. [be[test]] [get_host_byname] (0x0040): Failed to store host [(null)] [12]: Cannot allocate memory ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5297/head:pr5297 git checkout pr5297

4 13

[sssd PR#5283][opened] Add dyndns_auth_ptr support
by joakim-tjernlund 29 Sep '20

29 Sep '20

URL: https://github.com/SSSD/sssd/pull/5283 Author: joakim-tjernlund Title: #5283: Add dyndns_auth_ptr support Action: opened PR body: """ Allows to specify auth method for DNS PTR updates. Default to same as dyndns_auth. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5283/head:pr5283 git checkout pr5283

4 28

[sssd PR#5302][opened] conf: disable python2 bindings by default
by pbrezina 29 Sep '20

29 Sep '20

URL: https://github.com/SSSD/sssd/pull/5302 Author: pbrezina Title: #5302: conf: disable python2 bindings by default Action: opened PR body: """ Python2 is being fully replaced by Python3 on modern distros so there is no need to build the bindings by default. We even don't ship python2 packages in Fedora for quite some time now. Keeping this on by default requires using --without-python2-bindings on modern distributions where python2 is not installed by default. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5302/head:pr5302 git checkout pr5302

3 13

[sssd PR#5252][opened] Add offline_timeout_max option to control offline interval backoff
by deastoe 23 Sep '20

23 Sep '20

URL: https://github.com/SSSD/sssd/pull/5252 Author: deastoe Title: #5252: Add offline_timeout_max option to control offline interval backoff Action: opened PR body: """ The offline_timeout period determines the minimum time between attempts of a data provider to go back online, if it is offline due to eg. unreachable servers. Each time this check fails there is a backoff factor applied meaning there can be up to 60 minutes between these attempts. Here we introduce the offline_timeout_max option which allows the the maximum period between attempts to be defined in the configuration, instead of the default 60 minutes; therefore providing more flexibility. Setting offline_timeout_max to 0 disables the backoff functionality. Additionally fix two issues observed in be_ptask scheduling: - Backoff is not applied on the first re-schedule operation - The maximum backoff value (previously hardcoded) might not be reached. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5252/head:pr5252 git checkout pr5252

4 13

[sssd PR#5299][opened] dp: fix potential race condition in provider's sbus server
by pbrezina 17 Sep '20

17 Sep '20

URL: https://github.com/SSSD/sssd/pull/5299 Author: pbrezina Title: #5299: dp: fix potential race condition in provider's sbus server Action: opened PR body: """ We can hit a segfault if provider start is somehow delayed. - dp_init_send - sbus_server_create_and_connect_send - sbus_server_create (*) - dp_init_done (callback for sbus_server_create_and_connect_send) - sbus_server_create_and_connect_recv - sbus_server_set_on_connection (sets clients data and creates dp_cli) At (*) sbus server is already created and accepts new connections once we get into tevent loop. So it is possible that the client connects to server before sbus_server_set_on_connection is called and thus the client is not properly initialized. However it should not happen in normal start because providers are started before responders and it can happen only if data provider startup is somehow delay. You can use this diff to reproduce the crash: ```diff --- a/src/providers/data_provider_be.c +++ b/src/providers/data_provider_be.c @@ -702,6 +702,8 @@ int main(int argc, const char *argv[]) uid_t uid; gid_t gid; + sleep(5); + struct poptOption long_options[] = { POPT_AUTOHELP SSSD_MAIN_OPTS ``` Resolves: https://github.com/SSSD/sssd/issues/5298 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5299/head:pr5299 git checkout pr5299

2 24

[sssd PR#5270][opened] CONFDB: fixed compilation warning
by alexey-tikhonov 04 Sep '20

04 Sep '20

URL: https://github.com/SSSD/sssd/pull/5270 Author: alexey-tikhonov Title: #5270: CONFDB: fixed compilation warning Action: opened PR body: """ Fixed following compilation warning: ``` ../src/confdb/confdb.c: In function ‘confdb_get_domains’: ../src/confdb/confdb.c:2499:12: warning: ‘enabled’ may be used uninitialized in this function [-Wmaybe-uninitialized] ``` """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5270/head:pr5270 git checkout pr5270

3 20

[sssd PR#5294][opened] krb5: only try pkinit with Smartcard credentials
by sumit-bose 04 Sep '20

04 Sep '20

URL: https://github.com/SSSD/sssd/pull/5294 Author: sumit-bose Title: #5294: krb5: only try pkinit with Smartcard credentials Action: opened PR body: """ Currently pkinit is tried if a Smartcard is present. But depending on the used PAM service and other configurations it might happen that the user didn't provide the Smartcard PIN but e.g. the password. Hence, before trying pkinit we should check if the right credentials are available. Resolves: https://github.com/SSSD/sssd/issues/5290 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5294/head:pr5294 git checkout pr5294

3 12

[sssd PR#269][opened] Add support for ActiveDirectory's logonHours restrictions
by NWilson 03 Sep '20

03 Sep '20

URL: https://github.com/SSSD/sssd/pull/269 Author: NWilson Title: #269: Add support for ActiveDirectory's logonHours restrictions Action: opened PR body: """ This is a straightforward patch for denying access to a user when the user is not permitted to access their account due to logonHours restrictions. This matches the default behaviour for domain-joined Windows machines. When outside the logonHours, all types of authentication are denied (password/Kerberos/certificate) - so it is appropriate to put this check inside the PAM "account" rules. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/269/head:pr269 git checkout pr269

9 30

[sssd PR#5253][opened] libdirsrv should be modified to be compatible with new DS
by aborah-sudo 01 Sep '20

01 Sep '20

URL: https://github.com/SSSD/sssd/pull/5253 Author: aborah-sudo Title: #5253: libdirsrv should be modified to be compatible with new DS Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5253/head:pr5253 git checkout pr5253

5 26

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel August 2020