URL: https://github.com/SSSD/sssd/pull/5883
Title: #5883: Various fixes related forest and site name discovery
alexey-tikhonov commented:
"""
@pbrezina, it's not the only problem it is twice in master.
Another problem is commit in master doesn't match patch in PR (new file `src/man/include/dns_options.xml` absent in master).
"""
See the full comment at https://github.com/SSSD/sssd/pull/5883#issuecomment-986705230
URL: https://github.com/SSSD/sssd/pull/5883
Title: #5883: Various fixes related forest and site name discovery
sumit-bose commented:
"""
> Since this claims to fix https://bugzilla.redhat.com/show_bug.cgi?id=2006866 , this also need to be backported to 1-16 branch.
>
> @sumit-bose, does this apply cleanly or is dedicated PR required?
Hi,
only the last patch fails because the man page entry for `dns_resolver_server_timeout` is missing in 1-16, the option itself exists. So what would be the preferred solution, drop the hunk with the man page change or add a patch with the man page entries first? Funny enough, the entry was added twice in master 43b9b0922a and 7190f6b5d5, maybe one of the commits was meant for 1-16?
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/5883#issuecomment-985601568
URL: https://github.com/SSSD/sssd/pull/5883
Author: sumit-bose
Title: #5883: Various fixes related forest and site name discovery
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5883/head:pr5883
git checkout pr5883
URL: https://github.com/SSSD/sssd/pull/5883
Title: #5883: Various fixes related forest and site name discovery
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5883
* `master`
* c0941810fc3c3d74a00697349723f14e2f6bbdd2 - cldap: use dns_resolver_server_timeout timeout for cldap ping
* 724293d0873ee3229866ae4c13e1c8829375146f - ad: only send cldap-ping to our local domain
* 918abaf37d7f13d72b29863933e133bcbd24d87c - ad: make ad_srv_plugin_ctx_switch_site() public
* 99c4161910e542dd40c740032196d268c4163d07 - ad: use already discovered forest name
* 4508ef5f7183c640191393605ea163044d9ac267 - ad: move current site and forest name to a more global context
* b37e2713a9b86936f5b82a17e47757562900b911 - ad: require name when looking up root domain
"""
See the full comment at https://github.com/SSSD/sssd/pull/5883#issuecomment-985499303