URL: https://github.com/SSSD/sssd/pull/5636
Author: sergiodj
Title: #5636: Improve assertion when verifying paths for Python modules
Action: opened
PR body:
"""
In Ubuntu we're facing a problem where the 3 Python tests under
src/tests/*-test.py are failing due to cosmetical differences between
what the '.__file__' method returns and what 'MODPATH' ends up being.
I have not been able to pinpoint exactly what is causing this issue;
it only happens when SSSD is built inside a chroot environment (with
sbuild, for example). The logs look like this:
```python
F
======================================================================
FAIL: testImport (__main__.PyHbacImport)
Import the module and assert it comes from tree
----------------------------------------------------------------------
Traceback (most recent call last):
File "/<<PKGBUILDDIR>>/src/tests/pyhbac-test.py", line 91, in testImport
self.assertEqual(pyhbac.__file__, MODPATH + "/pyhbac.so")
AssertionError: '/<<PKGBUILDDIR>>/build/./tp_pyhbac_xw2omut2/pyhbac.so' != './tp_pyhbac_xw2omut2/pyhbac.so'
- /<<PKGBUILDDIR>>/build/./tp_pyhbac_xw2omut2/pyhbac.so
+ ./tp_pyhbac_xw2omut2/pyhbac.so
```
Given that the intention of the test is to verify that the two paths
are equal, I suggest that we do this slight improvement and call
'os.path.realpath' before comparing both paths. This way we guarantee
that they're both properly canonicalized.
I have verified that the tests still pass with this change.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5636/head:pr5636
git checkout pr5636
URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: opened
PR body:
"""
Since 2.5.0 I had these 3 tests fail with the following assertion error:
```
======================================================================
FAIL: testImport (__main__.PyHbacImport)
Import the module and assert it comes from tree
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/sssd/src/sssd-2.5.0/src/tests/pyhbac-test.py", line 91, in testImport
self.assertEqual(pyhbac.__file__, MODPATH + "/pyhbac.so")
AssertionError: '/build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so' != './tp_pyhbac_za3ox6lp/pyhbac.so'
- /build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so
+ ./tp_pyhbac_za3ox6lp/pyhbac.so
```
I don't know what changed but the issue here is related to a long-standing bug [1] in `tempfile.mkdtemp` where the returned path is not absolute if the dir parameter is relative, despite the documentation saying that the returned path is always absolute.
[1] https://bugs.python.org/issue7325
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651
URL: https://github.com/SSSD/sssd/pull/5724
Author: elkoniu
Title: #5724: [WIP] SDAP: Continue when parsing entry fails
Action: opened
PR body:
"""
Configuration: IPA data provider with AD trust enabled
In some scenarios when processing entry fail it may lead
to marking the whole backend as offline. This PR
implements skipping broken entries instead of triggering fail.
Resolves: https://github.com/SSSD/sssd/issues/4893
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5724/head:pr5724
git checkout pr5724
URL: https://github.com/SSSD/sssd/pull/5764
Author: aborah-sudo
Title: #5764: Tests: Suppress log message
Action: opened
PR body:
"""
Suppress log message "[sssd] [service_signal_done]
(0x0010): Unable to signal service [2]:
No such file or directory" during logrote
bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1909755
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5764/head:pr5764
git checkout pr5764
URL: https://github.com/SSSD/sssd/pull/5743
Author: pbrezina
Title: #5743: ad: fallback to ldap if cldap is not available in libldap
Action: opened
PR body:
"""
Some distributions do not have cldap support available in libldap. Now
we fallback to ad ping over ldap conditionally during build time.
Resolves: https://github.com/SSSD/sssd/issues/5720
```
:fixes: AD ping is now sent over `ldap` if `cldap` support is not available
during build. This helps to build SSSD on distributions without `cldap`
support in `libldap`.
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5743/head:pr5743
git checkout pr5743