URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: [WiP] Sources cleanup - part 3.
alexey-tikhonov commented:
"""
Sorry I didn't indicate this is work-in-progress yet.
Remaining steps here are:
- incorporate "lib secrets" into KCM since there are no other users
- to check if `kcm_ops_queue*` layer is still needed (most probably answer is "no" because only sync backends are now available) and remove if not
- get rid of encrypted/JSON payload support in KCM
Then "lib secrets" can drop support of encrypted payload, and probably utils crypto can drop some helpers, etc, but I didn't check it yet.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-908192570
URL: https://github.com/SSSD/sssd/pull/5746
Author: assafmo
Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705)
Action: opened
PR body:
"""
This PR fixes the exit condition when searching for a token in p11_child/do_card, specifically in case a token is present in a slot, but there are empty slots before it.
This PR partially fixes issue #5025, thanks to this comment by @sumit-bose: https://github.com/SSSD/sssd/issues/5025#issuecomment-801842175
:relnote: p11_child does not stop at the first empty slot when searching for tokens
This PR is a redo of PR #5705, because it was orphaned and changes were requested by the maintainers.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5746/head:pr5746
git checkout pr5746
URL: https://github.com/SSSD/sssd/pull/5760
Author: dpward
Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card()
Action: opened
PR body:
"""
This restores the previous behavior of `--wait_for_card`, and fixes issues with initialization and cleanup.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5760/head:pr5760
git checkout pr5760
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: [WiP] Sources cleanup - part 3.
alexey-tikhonov commented:
"""
@aborah-sudo, is this test executed in PR CI?
At the moment I don't understand how both methods can succeed, because it seems depending on execution order either 'nsswitch.conf::subid' isn't set or IPA subid range isn't generated.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-912826564
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: [WiP] Sources cleanup - part 3.
alexey-tikhonov commented:
"""
@aborah-sudo, is this test executed in PR CI?
At the moment I don't understand how both methods can succeed, because it seems depending on execution order either 'nsswitch.conf::subid' isn't set or IPA subid range isn't generated.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-912826564