From jhrozek at redhat.com Thu Aug 20 12:53:06 2015 Content-Type: multipart/mixed; boundary="===============4713804080947197186==" MIME-Version: 1.0 From: Jakub Hrozek To: sssd-devel at lists.fedorahosted.org Subject: Re: [SSSD] German po4a translation Date: Fri, 08 Nov 2013 13:05:04 +0100 Message-ID: <20131108120504.GF4481@hendrix.brq.redhat.com> In-Reply-To: 527CC5EA.5040602@vollbio.de --===============4713804080947197186== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Nov 08, 2013 at 12:07:22PM +0100, Chris Leick wrote: > Hi Jakub, > = > Chris Leick: > >Hi Jakub, > >>> > >>>Would you like to submit a patch for the bugs that come from > >>>the man pages > >>>or would you prefer if we did it? The man pages are XML > >>>DocBook documents > >>>located in src/man in the SSSD checkout. > > > >Ok. I will sent patches. > = > You can apply the patch attached to the xml files. > = > Kind regards, > Chris Thank you, see a couple of remarks in-line. > diff -ru sssd/src/man/include/ldap_id_mapping.xml sssd_new/src/man/includ= e/ldap_id_mapping.xml > --- sssd/src/man/include/ldap_id_mapping.xml 2013-11-08 11:23:39.31384760= 0 +0100 > +++ sssd_new/src/man/include/ldap_id_mapping.xml 2013-11-08 11:49:49.8498= 01198 +0100 > @@ -168,7 +168,7 @@ > > When this option is configured, domains will= be > allocated starting with slice zero and incre= asing > - monatomically with each additional domain. > + monotomically with each additional domain. I think the right spelling here would be "monotonically". > > > NOTE: This algorithm is non-deterministic (it > diff -ru sssd/src/man/include/seealso.xml sssd_new/src/man/include/seeals= o.xml > --- sssd/src/man/include/seealso.xml 2013-11-08 11:23:39.313847600 +0100 > +++ sssd_new/src/man/include/seealso.xml 2013-11-08 12:01:49.941779917 +0= 100 > @@ -2,25 +2,19 @@ > SEE ALSO > > > - sssd8 > - , > - > - sssd.conf5 > + sssd-ad5 > , > > - sssd-ldap5 > + sssd-ipa5 > , > > sssd-krb55 > , > > - sssd-simple5 > - , > - > - sssd-ipa5 > + sssd-ldap5 > , > > - sssd-ad5 > + sssd-simple5 > , > > > @@ -29,6 +23,12 @@ > , > > > + sssd.conf5 > + , > + > + pam_sss8 > + , > + > sss_cache8 > , > > @@ -41,19 +41,10 @@ > sss_groupdel8<= /manvolnum> > , > > - sss_groupshow8= > - , > - > sss_groupmod8<= /manvolnum> > , > > - sss_useradd8 > - , > - > - sss_userdel8 > - , > - > - sss_usermod8 > + sss_groupshow8= > , > > sss_obfuscate8= > @@ -61,9 +52,6 @@ > > sss_seed8 > , > - > - sssd_krb5_locator_plugin<= manvolnum>8 > - , > > > sss_ssh_authorizedkeys > @@ -75,7 +63,19 @@ > , > > > - pam_sss8 > + sss_useradd8 > + , > + > + sss_userdel8 > + , > + > + sss_usermod8 > + , > + > + sssd8 > + , > + > + sssd_krb5_locator_plugin<= manvolnum>8 > . > > These changes just re-order the list, right? > diff -ru sssd/src/man/pam_sss.8.xml sssd_new/src/man/pam_sss.8.xml > --- sssd/src/man/pam_sss.8.xml 2013-11-08 11:23:39.313847600 +0100 > +++ sssd_new/src/man/pam_sss.8.xml 2013-11-08 11:44:11.721811179 +0100 > @@ -23,19 +23,19 @@ > > pam_sss.so > > - quiet > + quiet > > > - forward_pass > + forward_pass > > > - use_first_pass > + use_first_pass > > > - use_authtok > + use_authtok > > > - retry=3DN > + retry=3DN Sorry, I don't think this change is correct, I can't build the man page with these elements: /home/remote/jhrozek/devel/sssd/src/man/pam_sss.8.xml:25: element arg: validity error : Element literal is not declared in arg list of possible children /home/remote/jhrozek/devel/sssd/src/man/pam_sss.8.xml:28: element arg: validity error : Element literal is not declared in arg list of possible children /home/remote/jhrozek/devel/sssd/src/man/pam_sss.8.xml:31: element arg: validity error : Element literal is not declared in arg list of possible children /home/remote/jhrozek/devel/sssd/src/man/pam_sss.8.xml:34: element arg: validity error : Element literal is not declared in arg list of possible children /home/remote/jhrozek/devel/sssd/src/man/pam_sss.8.xml:37: element arg: validity error : Element literal is not declared in arg list of possible children > > > > diff -ru sssd/src/man/sssd-ad.5.xml sssd_new/src/man/sssd-ad.5.xml > --- sssd/src/man/sssd-ad.5.xml 2013-11-08 11:23:39.337847600 +0100 > +++ sssd_new/src/man/sssd-ad.5.xml 2013-11-08 11:47:03.049806124 +0100 > @@ -72,7 +72,7 @@ > Active Directory, you should set > > ldap_id_mapping =3D False > - > + . When I built the man page, the dot appears on its own line: want to disable ID mapping and instead rely on POSIX attributes defined in Active Directory, you should set ldap_id_mapping =3D False . In order to retrieve users > In order to retrieve users and groups using POSIX attributes= from trusted > domains, the AD administrator must make sure that the POSIX = attributes > are replicated to the Global Catalog. > diff -ru sssd/src/man/sssd.conf.5.xml sssd_new/src/man/sssd.conf.5.xml > --- sssd/src/man/sssd.conf.5.xml 2013-11-08 11:23:39.337847600 +0100 > +++ sssd_new/src/man/sssd.conf.5.xml 2013-11-08 12:02:45.045778290 +0100 > @@ -181,7 +181,7 @@ > > > Each domain can have an individual forma= t string configured. > - see DOMAIN SECTIONS for more info on thi= s option. > + See DOMAIN SECTIONS for more info on thi= s option. > > > > @@ -239,7 +239,7 @@ > > This string will be used as a default do= main > name for all names without a domain name > - component. The main use case is environm= ents > + component. The main use case are environ= ments I think the original was correct here, the sentence reads to me as the singular is used together with "use case" not "environments". But I'm not an English native speaker either.. > where the primary domain is intended for= managing host > policies and all users are located in a = trusted domain. > The option allows those users > @@ -269,7 +269,7 @@ > Settings that can be used to configure different services > are described in this section. They should reside in the > [$NAME] section, for example, > - for NSS service, the section would be [nss] > + for NSS service, the section would be [nss]. > > = > > @@ -408,7 +408,7 @@ > > > How many seconds should nss_sss cache enumer= ations > - (requests for info about all users) > + (requests for info about all users)? I don't think the question mark looks good here, sorry. > > > Default: 120 > @@ -918,8 +918,8 @@ > > > UID and GID limits for the domain. If a doma= in > - contains an entry that is outside these limi= ts, it > - is ignored. > + contains an entry that is outside these limi= ts, this > + entry is ignored. > > > For users, this affects the primary GID limi= t. The > @@ -1352,7 +1352,7 @@ > > The access control provider used for the dom= ain. > There are two built-in access providers (in > - addition to any included in installed backen= ds) > + addition to any included in installed backen= ds). > Internal special providers are: > > > @@ -1853,7 +1853,7 @@ > > The local domain section > > - This section contains settings for domain that stores us= ers and > + This section contains settings for domains that stores u= sers and I think there is one more change to be done, instead of "domains that stores users", shouldn't it say "domains that store users" ? > groups in SSSD native database, that is, a domain that u= ses > id_provider=3Dlocal. > > @@ -1962,7 +1962,7 @@ > > > The command that is run after a user is remo= ved. > - The command us passed the username of the us= er being > + The command is passed the username of the us= er being > removed as the first and only parameter. The= return > code of the command is not taken into accoun= t. > > diff -ru sssd/src/man/sssd-krb5.5.xml sssd_new/src/man/sssd-krb5.5.xml > --- sssd/src/man/sssd-krb5.5.xml 2013-11-08 11:23:39.337847600 +0100 > +++ sssd_new/src/man/sssd-krb5.5.xml 2013-11-08 11:48:46.173803079 +0100 > @@ -348,7 +348,7 @@ > d for days. > > > - If there is no unit given s is > + If there is no unit given, s is > assumed. > > > @@ -423,7 +423,7 @@ > > demand to use FAST. The > authentication fails if the server does not > - require fast. > + require FAST. > > > Default: not set, i.e. FAST is not used. > diff -ru sssd/src/man/sssd-ldap.5.xml sssd_new/src/man/sssd-ldap.5.xml > --- sssd/src/man/sssd-ldap.5.xml 2013-11-08 11:23:39.337847600 +0100 > +++ sssd_new/src/man/sssd-ldap.5.xml 2013-11-08 11:42:11.945814725 +0100 > @@ -149,7 +149,7 @@ > The namingContexts attribute must have a > single value with the DN of the search base = of the > LDAP server to make this work. Multiple valu= es are > - are not supported. > + not supported. > > > > @@ -356,7 +356,7 @@ > > The LDAP attribute that contains the objectS= ID of > an LDAP user object. This is usually only > - necessary for ActiveDirectory servers. > + necessary for Active Directory servers. > > > Default: objectSid for ActiveDirectory, not = set > @@ -705,7 +705,7 @@ > ldap_user_authorized_service (string) > > > - If access_provider=3Dldap and > + If using access_provider=3Dldap and Hm, the original sentence looked OK to me, the "using" didn't sound good to you? > ldap_access_order=3Dauthorized_service, SSSD= will > use the presence of the authorizedService > attribute in the user's LDAP entry to determ= ine > @@ -733,7 +733,7 @@ > ldap_user_authorized_host (string) > > > - If access_provider=3Dldap and > + If using access_provider=3Dldap and Same here > ldap_access_order=3Dhost, SSSD will use the = presence > of the host attribute in the user's LDAP ent= ry to > determine access privilege. > @@ -826,7 +826,7 @@ > > The LDAP attribute that contains the objectS= ID of > an LDAP group object. This is usually only > - necessary for ActiveDirectory servers. > + necessary for Active Directory servers. > > > Default: objectSid for ActiveDirectory, not = set > @@ -1038,7 +1038,7 @@ > ldap_service_name (string) > > > - The LDAP attribute that contains the name of > + The LDAP attribute that contains the names of > service attributes and their aliases. > > > @@ -1434,7 +1434,7 @@ > > = > > - ldap_min_id, ldap_max_id (interger) > + ldap_min_id, ldap_max_id (integer) > > > In contrast to the SID based ID mapping whic= h is The rest of the changes looks good to me. Thanks again for improving the documentation. Would it be OK for you to send a git-formatted patch in the next iteration? If not, a diff is fine, I can apply it myself. --===============4713804080947197186==--