From jhrozek at redhat.com Thu Aug 20 12:52:19 2015
Content-Type: multipart/mixed; boundary="===============7277884435128926656=="
MIME-Version: 1.0
From: Jakub Hrozek <jhrozek at redhat.com>
To: sssd-devel at lists.fedorahosted.org
Subject: Re: [SSSD] [PATCH] man: improve sssd-sudo manual page
Date: Mon, 16 Sep 2013 16:13:03 +0200
Message-ID: <20130916141303.GW28667@hendrix.brq.redhat.com>
In-Reply-To: 523317E5.5020603@redhat.com

--===============7277884435128926656==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 13, 2013 at 03:49:25PM +0200, Pavel B=C5=99ezina wrote:
> https://fedorahosted.org/sssd/ticket/2085

> From 2a6573c0ceeaaa51e155a01719bbb283164705cf Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Pavel=3D20B=3DC5=3D99ezina?=3D <pbrezina(a)redhat.com>
> Date: Fri, 13 Sep 2013 15:48:10 +0200
> Subject: [PATCH] man: improve sssd-sudo manual page
> =

> Resolves:
> https://fedorahosted.org/sssd/ticket/2085
> ---
>  src/man/sssd-sudo.5.xml | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> =

> diff --git a/src/man/sssd-sudo.5.xml b/src/man/sssd-sudo.5.xml
> index 361fdb7b210df280cffce8c9147257bd0b3ecacb..3262eeababe25e6bdae509c91=
c22cee493f4a2bd 100644
> --- a/src/man/sssd-sudo.5.xml
> +++ b/src/man/sssd-sudo.5.xml
> @@ -66,11 +66,30 @@ sudoers: files sss
>                  <manvolnum>5</manvolnum>
>              </citerefentry>.
>          </para>
> +        <para>
> +            <emphasis>Note</emphasis>: in order to use netgroups or IPA
> +            hostgroups in sudo rules, you also need to correctly set
> +            <citerefentry>
> +                <refentrytitle>nisdomainname</refentrytitle>
> +                <manvolnum>1</manvolnum>
> +            </citerefentry>
> +            to your domain name.
                        ^^^^^^^
                This is ambiguous. Do you mean DNS domain name, IPA
                domain name...?

> +        </para>
>      </refsect1>
>  =

>      <refsect1 id=3D'sssd'>
>          <title>Configuring SSSD to fetch sudo rules</title>
>          <para>
> +            All configuration that is needed on SSSD side is to put "sud=
o"

What about extend the list of services with "sudo" ?

> +            to <emphasis>services</emphasis> in [sssd] section of
> +            <citerefentry>
> +                <refentrytitle>sssd.conf</refentrytitle>
> +                <manvolnum>5</manvolnum>
> +            </citerefentry>. To speed up the LDAP lookups, you can also =
set
> +            search base for sudo rules using
> +            <emphasis>ldap_sudo_search_base</emphasis> option.
> +        </para>
> +        <para>
>              The following example shows how to configure SSSD to downloa=
d sudo
>              rules from an LDAP server.
>          </para>
> @@ -89,8 +108,8 @@ ldap_sudo_search_base =3D ou=3Dsudoers,dc=3Dexample,dc=
=3Dcom
>  </programlisting>
>          </para>
>          <para>
> -            When the SSSD is configured to use the IPA provider, the sudo
> -            provider is automatically enabled. The sudo search base
> +            When the SSSD is configured to use IPA as the ID provider,
> +            the sudo provider is automatically enabled. The sudo search =
base
>              is configured to use the compat tree (ou=3Dsudoers,$DC).
>          </para>
>      </refsect1>
> -- =

> 1.7.11.7
> =


The content looks good, I'd just like to run the patch by some English
native speaker.

--===============7277884435128926656==--