-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/20/2010 11:03 AM, Sumit Bose wrote:
On Mon, Dec 20, 2010 at 04:13:10PM +0100, Sumit Bose wrote:
> On Mon, Dec 20, 2010 at 02:41:18PM +0100, Sumit Bose wrote:
>> On Mon, Dec 20, 2010 at 01:46:49PM +0100, Sumit Bose wrote:
>>> On Fri, Dec 17, 2010 at 09:19:56AM -0500, Stephen Gallagher wrote:
On 12/16/2010 08:51 AM, Jakub Hrozek wrote:
>>>>>> On 12/16/2010 01:31 PM, Stephen Gallagher wrote:
>>>>>>> On 12/16/2010 06:36 AM, Jakub Hrozek wrote:
>>>>>>>> On 12/15/2010 09:48 PM, Stephen Gallagher wrote:
>>>>>>>>> Nack. These patches fail to build when configure is
run in a directory
>>>>>>>>> other than the root of the source checkout (aka a
parallel build directory)
>>>>>>
>>>>>>>>> See attached build log attempting to build from
/dev/shm/test-build.
>>>>>>
>>>>>>
>>>>>>>> Thanks, I missed this case in my testing (or rather, I
though that make
>>>>>>>> distcheck does essentially the same thing).
>>>>>>
>>>>>>>> Attached is a patch that always builds the included xml
files as the
>>>>>>>> real xml sources depend on them.
>>>>>>
>>>>>>
>>>>>>> Nack. Running "make translated-manpages" now works
in a parallel build
>>>>>>> dir, but running "make distcheck" still fails.
>>>>>>
>>>>>>> Logs attached.
>>>>>>
>>>>>>> distcheck-clean.log shows the attempt to run "make
distcheck" from a
>>>>>>> perfectly clean checkout with this patch (patch applied, then
'git reset
>>>>>>> --hard' to make sure there are no pre-generated
translation files)
>>>>>>
>>>>>>> distcheck-translated-manpages shows the attempt to run
"make distcheck"
>>>>>>> from a checkout that was configured and then had "make
>>>>>>> translated-manpages" run on it.
>>>>>>
>>>>>>> Both of these were run from a parallel build dir.
>>>>>>
>>>>>>
>>>>>>
>>>>>> Sumit managed to fix this issue. Attached is my previous patch
with his fix.
Nack. Patch does not update translations when "make distdir" is run.
This is needed for ensuring that releases always have the latest
translation data available.
>>>>
>>>> The attached patch should fix it, please apply it on top of the other
>>>> two.
>>>>
>>>> bye,
>>>> Sumit
>>>
>>> Here is a different version of the patch with the distdir-hook target
>>> instead of dist-hook.
>>>
>>> bye,
>>> Sumit
>>>
>>
>> Another new version which can create a missing po directory.
>>
>> bye,
>> Sumit
> Sorry, found another issue. I've added the other two related patches for
> your convenience, too.
> bye,
> Sumit
>>
>>>>
Sorry, this is still a Nack.
Patch 0001 doesn't apply cleanly on master. I had to tweak it to get it
to work (conflict with the DISTCHECK_CONFIGURE_FLAGS in the patch made
it fail to apply)
Once applied, I ran the following test:
cd /dev/shm
rm -Rf sssd; mkdir sssd; cd sssd
~/workspace/sssd/configure && make distcheck
This failed with:
make[2]: Leaving directory `/dev/shm/sssd/sssd-1.5.0/_build/po'
(cd src/man && make top_distdir=../../sssd-1.5.0
distdir=../../sssd-1.5.0/src/man \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[2]: Entering directory `/dev/shm/sssd/sssd-1.5.0/_build/src/man'
/bin/mkdir -p po
for lang in cs; do \
/bin/mkdir -p $lang; \
/bin/mkdir -p $lang/include; \
done
touch prepare.stamp
rm -f po/po4a.cfg
echo "[po4a_langs] cs" >> po/po4a.cfg
echo "[po4a_paths] ../../../src/man/po/sssd-docs.pot
\$lang:../../../src/man/po/\$lang.po" >> po/po4a.cfg
for file in ../../../src/man/sss_groupmod.8.xml
../../../src/man/sssd.conf.5.xml ../../../src/man/sss_groupshow.8.xml
../../../src/man/sssd-ldap.5.xml ../../../src/man/pam_sss.8.xml
../../../src/man/sssd_krb5_locator_plugin.8.xml
../../../src/man/sssd-simple.5.xml ../../../src/man/sssd-ipa.5.xml
../../../src/man/sss_useradd.8.xml ../../../src/man/sss_obfuscate.8.xml
../../../src/man/sssd.8.xml ../../../src/man/sssd-krb5.5.xml
../../../src/man/sss_groupadd.8.xml ../../../src/man/sss_userdel.8.xml
../../../src/man/sss_groupdel.8.xml ../../../src/man/sss_usermod.8.xml
../../../src/man/include/service_discovery.xml
../../../src/man/include/upstream.xml
../../../src/man/include/failover.xml
../../../src/man/include/param_help.xml; do \
echo "[type:docbook] $file \$lang:\$lang/$file" >> po/po4a.cfg; \
done
po4a --option doctype=docbook --package-name sssd-docs --package-version
1.5.0 --msgid-bugs-address sssd-devel(a)redhat.com --copyright-holder "Red
Hat" --no-backups --no-translations ./po/po4a.cfg
Can't move /tmp/vKC8899LFt to ../../../src/man/po/sssd-docs.pot:
Permission denied.
make[2]: *** [../../../src/man/po/sssd-docs.pot] Error 13
make[2]: Leaving directory `/dev/shm/sssd/sssd-1.5.0/_build/src/man'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/dev/shm/sssd/sssd-1.5.0/_build'
make: *** [distcheck] Error 1
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk0PicIACgkQeiVVYja6o6MQXwCgq1c6KqXc4qijjELnJ8OKVdyK
fQkAn2U3yPlyPT0giWS/cXusIRGUTele
=k4r1
-----END PGP SIGNATURE-----