On 08/18/2015 03:21 PM, Jakub Hrozek wrote:
On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote:
>
https://fedorahosted.org/sssd/ticket/2737
>
> Hi, it should work... :-) However, I wanted to make import as transaction so
> no changes are made if some error occurs, but I had some troubles with it so
> I gave up eventually.
>
> Of course, it would be quite difficult to make it safe across domains thus
> my intention was only to ensure that either all changes are done in a domain
> or none. But still leaving the possibility that changes are commited in one
> domain but cancelled in another.
>
> I tried to start sysdb transaction on all used domains and then
> commit/cancel it, writing some neat mechanism for it. However, I
> occasionally run into a problem when data provider hangs when trying to safe
> a user. It looked like some sort of race condition.
>
> Unfortunately I managed to delete the code so I can't show it to you, I
> think it would be a nice feature so if anyone familiar with ldb want to step
> in, he's welcome.
> From 24655f677acf9f64201a611ababdcfeff4317037 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
> Date: Sat, 15 Aug 2015 16:42:27 +0200
> Subject: [PATCH 2/2] sss_override: add import and export
>
> Resolves:
>
https://fedorahosted.org/sssd/ticket/2737
this review is about sss_override.c:
- please add a man page explanation, ideally with examples of the
import/export files
- we need to fix the FQDNs. I would also prefer to print FQDNs on
export
Yes, I'll do it in separate patch since there is a ticket for that. (2757)
BTW fq names works correctly, unless you have use_fully_qualified_names
= True.
- please warn that sssd must be restarted after import
This works for me with this version.
- as an additional fix, we should support UPNs as well in the
first
column. See the Dell specification - that's what they use. In many
cases, the FQDN will be the same as UPN, but not always. But I
don't want to block the inclusion over that.
Will do with 2757.