Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

[Petr Cech]

Hello,

there are fixed patches attached.

On 09/18/2015 11:08 AM, Lukas Slebodnik wrote:
> > > > > > >>>-    -version-info 0:1:0
> > > > > > >>>+    -version-info 1:0:1
> > > > > > >Lukas, are you sure this version number 1:0:1? If you're really sure this
> > > > > > >number, I have not understood it properly.
>
> You might also look into generated library name for old version-info and for
> new version-info. The SONAME should be the same.
>
> sh$ objdump -p /lib64/libipa_hbac.so | grep SONAME
>    SONAME               libipa_hbac.so.0

I checked it, thanks.
> > > > > I have not read the patch at all, just adding a link about version info
> > >
> > > [1]
> > > > > https://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info
> > > > >
> > > > > The trick to follow this guide is that it's really an algorithm, so you
> > > > > shouldn't stop at the first change, but continue (potentially reverting
> > > > > or overwriting previous changes)
> > >
> > > I understand, how we changed -version-info (it is exactly by steps as
> > > described in [1]), but I don't understand clearly changes in .exports.
> > > Petr
>
> because there was a copy&paste bug in diff.

Well, it's OK. I was afraid that I didn't understand anything.
> As I wrote in previous mail; new function should not be added
> to old version block.

It looks more clear for me now.

Petr