>From 73a0d9a23c3e73fb201065dea4d03e7be0f86329 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Tue, 3 Sep 2013 09:45:34 +0200 Subject: [PATCH] UTIL: Use standard maximum value of type size_t It is better to use standard constant for maximum value of type size_t, instead of reinventing wheel with own defined constant SIZE_T_MAX This patch replace string "SIZE_T_MAX" -> "SIZE_MAX" --- src/tests/util-tests.c | 12 ++++++------ src/util/util_safealign.h | 5 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/tests/util-tests.c b/src/tests/util-tests.c index 4b0d5009c7c65f259f66aa66eb68281098164b74..9af12081dd64d0b94cae7a190bf7915181e3d57b 100644 --- a/src/tests/util-tests.c +++ b/src/tests/util-tests.c @@ -388,14 +388,14 @@ END_TEST START_TEST(test_size_t_overflow) { fail_unless(!SIZE_T_OVERFLOW(1, 1), "unexpected overflow"); - fail_unless(!SIZE_T_OVERFLOW(SIZE_T_MAX, 0), "unexpected overflow"); - fail_unless(!SIZE_T_OVERFLOW(SIZE_T_MAX-10, 10), "unexpected overflow"); - fail_unless(SIZE_T_OVERFLOW(SIZE_T_MAX, 1), "overflow not detected"); - fail_unless(SIZE_T_OVERFLOW(SIZE_T_MAX, SIZE_T_MAX), + fail_unless(!SIZE_T_OVERFLOW(SIZE_MAX, 0), "unexpected overflow"); + fail_unless(!SIZE_T_OVERFLOW(SIZE_MAX-10, 10), "unexpected overflow"); + fail_unless(SIZE_T_OVERFLOW(SIZE_MAX, 1), "overflow not detected"); + fail_unless(SIZE_T_OVERFLOW(SIZE_MAX, SIZE_MAX), "overflow not detected"); - fail_unless(SIZE_T_OVERFLOW(SIZE_T_MAX, ULLONG_MAX), + fail_unless(SIZE_T_OVERFLOW(SIZE_MAX, ULLONG_MAX), "overflow not detected"); - fail_unless(SIZE_T_OVERFLOW(SIZE_T_MAX, -10), "overflow not detected"); + fail_unless(SIZE_T_OVERFLOW(SIZE_MAX, -10), "overflow not detected"); } END_TEST diff --git a/src/util/util_safealign.h b/src/util/util_safealign.h index d1d7a4861415ee6b0a755f17247985857b23ed57..e7f34e147fa96171dd6a74a30dbc13581d20746c 100644 --- a/src/util/util_safealign.h +++ b/src/util/util_safealign.h @@ -30,11 +30,10 @@ #define _UTIL_SAFEALIGN_H #include - -#define SIZE_T_MAX ((size_t) -1) +#include #define SIZE_T_OVERFLOW(current, add) \ - (((size_t)(add)) > (SIZE_T_MAX - ((size_t)(current)))) + (((size_t)(add)) > (SIZE_MAX - ((size_t)(current)))) static inline void safealign_memcpy(void *dest, const void *src, size_t n, size_t *counter) -- 1.8.3.1