>From a34e2223d8223c39c06e12996da5034b18a0a708 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 26 Feb 2014 18:19:59 +0100 Subject: [PATCH] Remove useless assignment to function parameter Reported by: cppcheck void free_fun(struct info *info) free(info->name); free(info); info = NULL; ^^^^^^^^^^^ Assignment to function parameter has no effect outside the function. --- src/krb5_plugin/sssd_krb5_locator_plugin.c | 1 - src/providers/ipa/hbac_evaluator.c | 1 - src/sss_client/pam_sss.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/krb5_plugin/sssd_krb5_locator_plugin.c b/src/krb5_plugin/sssd_krb5_locator_plugin.c index a3a07d642fad848900c1af89255d40fc9d1a86bc..aa8d387a5d0be302e5cc98ddcf10ebce6957f3a5 100644 --- a/src/krb5_plugin/sssd_krb5_locator_plugin.c +++ b/src/krb5_plugin/sssd_krb5_locator_plugin.c @@ -250,7 +250,6 @@ void sssd_krb5_locator_close(void *private_data) free(ctx->kpasswd_addr); free(ctx->sssd_realm); free(ctx); - private_data = NULL; return; } diff --git a/src/providers/ipa/hbac_evaluator.c b/src/providers/ipa/hbac_evaluator.c index 6190fe27907d0fd4a5efbcbda7fa6c7ff2c94bbb..f40f9e0a7f16f5e012079c637b89c8e49ec5d15b 100644 --- a/src/providers/ipa/hbac_evaluator.c +++ b/src/providers/ipa/hbac_evaluator.c @@ -315,7 +315,6 @@ void hbac_free_info(struct hbac_info *info) free(info->rule_name); free(info); - info = NULL; } const char *hbac_error_string(enum hbac_error_code code) diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c index 638e211eea01d1f851201c34d95f57189645ea50..3a9fa6e1ef8759ce77ba2deff7d32bcfbcac513c 100644 --- a/src/sss_client/pam_sss.c +++ b/src/sss_client/pam_sss.c @@ -115,7 +115,6 @@ static void logger(pam_handle_t *pamh, int level, const char *fmt, ...) { static void free_exp_data(pam_handle_t *pamh, void *ptr, int err) { free(ptr); - ptr = NULL; } static void close_fd(pam_handle_t *pamh, void *ptr, int err) -- 1.8.5.3