On Mon, 2011-11-14 at 14:28 +0100, Jan Zelený wrote:
#54 Some new config options, please focus on this patch, I'm not entirely sure if my approach was the correct one.
Nack.
Looks mostly good, except that when you added the new host search base option, you don't check it in the ipa_get_id_options() function. You need to make sure to set it appropriately and call sdap_parse_search_base().
That's why I was asking for thorough review. I was basing the design on your implementation of similar option in HBAC code and I wasn't sure it's the right design. As I understand it, you'd prefer to have multiple search bases support for this option available, correct?
I have no objections, but if I'm to rewrite this, I think we should do the same thing in HBAC code, shouldn't we?
You are of course completely right, and I missed that in my initial patches.