Re: [SSSD] [PATCH] SDAP: Relax POSIX check

[Jakub Hrozek]

On Wed, Sep 23, 2015 at 09:26:53PM +0200, Pavel Březina wrote:
> On 09/22/2015 03:03 PM, Pavel Reichl wrote:
> > Hello,
> >
> > please see attached patch.
> >
> > Thanks!
>
> Hi,
> > state->filter = talloc_asprintf(state, "(|(%s=*)(%s=*))",
> > state->filter = talloc_asprintf(state,
> >    "(|(&(%s=*)(objectclass=%s))(&(%s=*)(objectclass=%s)))",
> >                               opts->user_map[SDAP_AT_USER_UID].name,
> >                                opts->group_map[SDAP_AT_GROUP_GID].name);
> >                                opts->user_map[SDAP_OC_USER].name,
> >                                opts->group_map[SDAP_AT_GROUP_GID].name,
> >                                opts->group_map[SDAP_OC_GROUP].name);
>
> I don't understand, how it got relaxed? The original filter already tests
> only for presence of uid or gid. Or am I missing something?

I think the main point is the removal of "goto done" if str-to-num
failed.

That should have been spelled out in the commit message :-)