On Tue, Jun 23, 2015 at 01:00:39PM +0200, Lukas Slebodnik wrote:
On (23/06/15 11:31), Jakub Hrozek wrote:
>On Tue, Jun 23, 2015 at 11:06:08AM +0200, Lukas Slebodnik wrote:
>> ehlo,
>>
>> simple patch is attached.
>>
>> LS
>
>> From 764e6e398487d585214b9b66388e74546390a973 Mon Sep 17 00:00:00 2001
>> From: Lukas Slebodnik <lslebodn(a)redhat.com>
>> Date: Tue, 23 Jun 2015 10:57:19 +0200
>> Subject: [PATCH] Bump version-info
>>
>> The function ref_array_debug was updated. There wasn't any other
>> changes to ref_array.
>>
>> New functions were added to collections:
>> col_get_dup_item, col_delete_item_with_cb, col_remove_item_with_cb
>>
>> New functions were added to ini_config:
>> ini_config_augment, ini_comment_construct and many functions
>> from ini_configmod.h
>> ---
>> Makefile.am | 6 +++---
>> version.m4 | 6 +++---
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index
e37884e612f23acddbb10e7a1f46eacc78908ef8..5b1da336189cb783ebc23f4241cb2bcb16fa16d7 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -142,7 +142,7 @@ libcollection_la_SOURCES = \
>> trace/trace.h
>> libcollection_la_DEPENDENCIES = collection/libcollection.sym
>> libcollection_la_LDFLAGS = \
>> - -version-info 4:0:0 \
>> + -version-info 5:0:1 \
>
>We follow these rules from
>https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
>
> - If the library source code has changed at all since the last update,
> then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
> - If any interfaces have been added, removed, or changed since the last
> update, increment current, and set revision to 0.
> - If any interfaces have been added since the last public release, then
> increment age.
>
>-> ACK
>
>
>> -Wl,--version-script=$(top_srcdir)/collection/libcollection.sym
>>
>> check_PROGRAMS += \
>> @@ -180,7 +180,7 @@ libref_array_la_SOURCES = \
>> trace/trace.h
>> libref_array_la_DEPENDENCIES = refarray/libref_array.sym
>> libref_array_la_LDFLAGS = \
>> - -version-info 3:0:2 \
>> + -version-info 3:1:2 \
>> -Wl,--version-script=$(top_srcdir)/refarray/libref_array.sym
>
>Here we only follow:
> - If the library source code has changed at all since the last update,
> then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
>
>-> ACK
>
>>
>> check_PROGRAMS += ref_array_ut
>> @@ -268,7 +268,7 @@ libini_config_la_LIBADD = \
>> libref_array.la \
>> libbasicobjects.la
>> libini_config_la_LDFLAGS = \
>> - -version-info 5:0:0 \
>> + -version-info 6:0:1 \
>
>Here we follow the same rules as with libcollection.
>
>> -Wl,--version-script=$(top_srcdir)/ini/libini_config.sym
>>
>> dist_noinst_DATA += \
>> diff --git a/version.m4 b/version.m4
>> index
45ff9e247ab8bfc0a9dcc2776989978bc709bfa4..8f4ce544134230488659cf7f379f8e73c2c33776 100644
>
>The changes are fine, but should be a different patch.
>
No problem two patches are attached.
Thank you, ACK to both. btw I also checked how the resulting symlinks
look like. For libcollection libcollection.so.4.1.0 appeared but 4.0.0
stays, similarly for libini_config 5.1.0 appeared in addition to 5.0.0.
For libref_array, 1.2.0 stays