>From 3fc1a23f5a8fecf3625384ec0caa5b82320a6cb3 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 7 Aug 2015 16:57:46 +0200 Subject: [PATCH 1/2] sbus: Initialize errno if constructing message fails and add debug messages --- src/sbus/sssd_dbus_request.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/sbus/sssd_dbus_request.c b/src/sbus/sssd_dbus_request.c index 6a012f1c669bb093b6934b13d9f4688c178d1dc2..888a0eeb53ed62f45ab4f95eec4508e960a6ca40 100644 --- a/src/sbus/sssd_dbus_request.c +++ b/src/sbus/sssd_dbus_request.c @@ -333,6 +333,9 @@ struct tevent_req *sbus_get_sender_id_send(TALLOC_CTX *mem_ctx, goto immediate; } + DEBUG(SSSDBG_TRACE_INTERNAL, + "Looking for identity of sender [%s]\n", sender); + key.type = HASH_KEY_STRING; key.str = discard_const(sender); ret = hash_lookup(conn->clients, &key, &value); @@ -379,6 +382,7 @@ struct tevent_req *sbus_get_sender_id_send(TALLOC_CTX *mem_ctx, DBUS_TYPE_STRING, &sender, DBUS_TYPE_INVALID); if (!dbret) { + ret = ERR_INTERNAL; goto immediate; } @@ -445,6 +449,7 @@ static void sbus_get_sender_id_done(DBusPendingCall *pending, void *ptr) DBUS_TYPE_UINT32, &uid, DBUS_TYPE_INVALID); if (!dbret) { + DEBUG(SSSDBG_CRIT_FAILURE, "Could not parse reply!\n"); ret = EIO; goto done; } @@ -457,6 +462,7 @@ static void sbus_get_sender_id_done(DBusPendingCall *pending, void *ptr) value.ul = state->uid; ret = hash_enter(state->conn->clients, &key, &value); if (ret != HASH_SUCCESS) { + DEBUG(SSSDBG_CRIT_FAILURE, "Could not add key to hash table!\n"); ret = EIO; goto done; } -- 2.4.3