On Mon, 2012-12-03 at 23:34 +0100, Jakub Hrozek wrote:
From 7b963c4d6ffcfb793feb22ca9a966a3f4c9d284f Mon Sep 17 00:00:00
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Tue, 27 Nov 2012 16:09:23 +0100
Subject: [PATCH 4/4] MEMBEROF: Implement the modify operation for
Code looks ok, but it definitely needs more commenting.
I see you haven't touched the big comments that explain how the memberof
plugin does calculation, thst's probably because the previous patch that
added ghost support didn't either.
I think we need a small blurb that explains how memberof is behaving wrt
ghost elements so that we can read what the code is trying to do and
correlate it with the code at hand to see that it does what is claimed.
In this case a comment is necessary because the code is too complex to
figure it out quickly just by looking at it.
Simo Sorce * Red Hat, Inc * New York