On 09/07/2016 02:24 PM, Jakub Hrozek wrote:
Hi,
sorry to come late, but I have one more request (last one, I promise..)
On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson <jstephen(a)redhat.com>
> Date: Fri, 26 Aug 2016 15:15:32 -0400
> Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink command-line option
>
> Removing monitor command-line option, to be superceded by
> sssd.conf option
[...]
> + if (opt_netlinkoff) {
> + fprintf(stderr, "Option --disable-netlink has been removed and "
> + "replaced as a Monitor option in sssd.conf\n");
> + poptPrintUsage(pc, stderr, 0);
> + return 1;
I would prefer if we were a little more graceful here and only called
DEBUG and sss_log() but did not abort the startup. I think it's better
to start SSSD in a degraded mode than not at all..
Hi Jakub,
No problem, patch updated.
> + }
> +
> if (!opt_daemon && !opt_interactive && !opt_genconf) {
> opt_daemon = 1;
> }