-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/01/2010 03:05 PM, Stephen Gallagher wrote:
> Patch 0004: Nack. Please check spelling/grammar in the manpage
entry.
> ("possible" is misspelled and "hour" should be plural)
> Also, please use something more descriptive than "dummy". That moniker
> should be reserved for actual dummy variables whose contents we don't
> care about.
> I'm wondering whether it makes sense to have the renewable length as an
> environment variable. I think it might be wiser to pass that as an
> argument. There may be times in the future where we want to
> differentiate renewable length by group or other distinguishing feature
> of an account.
After discussion on IRC, we're going to defer switching the environment
variables to arguments. Sumit will open a new enhancement ticket to
track this. So this portion of my review ceases to be a nack.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkz3uRoACgkQeiVVYja6o6NRzwCfZClDmKfVNphQ+O1Op7wEoPW5
ba8AnR5Kg65kfgVgcyMi8DR0rmopJXQi
=Alno
-----END PGP SIGNATURE-----