On Mon, Mar 09, 2015 at 11:24:31AM +0100, Pavel Reichl wrote:
>
> On 03/09/2015 10:13 AM, Sumit Bose wrote:
>> Hi,
>>
>> this is a patch I have in my tree for some time for debugging purposes.
>> Recently I've seen some bug reports with "ldb_modify failed"
messages in
>> the logs and I think this patch might help in those cases.
>>
>> Additionally I wonder if SSSDBG_MINOR_FAILURE is a suitable debug level
>> here. In most cases an error here prevents a user or group object to be
>> written to the cache, so maybe SSSDBG_CRIT_FAILURE is justified here?
>>
>> bye,
>> Sumit
>>
>>
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel(a)lists.fedorahosted.org
>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> Hello Sumit,
>
> when compiling at my environment, I'm seeing this warning:
>
> ../src/db/sysdb_ops.c: In function 'sysdb_set_entry_attr':
> ../src/db/sysdb_ops.c:717:21: warning: format '%u' expects argument of type
> 'unsigned int', but argument 6 has type 'size_t' [-Wformat=]
> DEBUG(SSSDBG_MINOR_FAILURE, " Value[%u]: [%s].\n",
>
>
> Would you consider amending the patch?
> - DEBUG(SSSDBG_MINOR_FAILURE, " Value[%u]: [%s].\n",
> + DEBUG(SSSDBG_MINOR_FAILURE, " Value[%zu]: [%s].\n",
Of course, thank you for catching this, new version attached.
bye,
Sumit
> This seem to remove the warning for me.
>
> Thanks!
>
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Thanks:
ci: failed on RHEL 7 on test-negcache - I think this is a false positive.