On 11/14/2012 1:41 PM, Stephen Gallagher wrote:
Minor: Please use the new SSSDBG macros in confdb_get_domain_internal(). You don't need to update the existing code, but all new code should use the macros. See util.h for a listing of them.
Done.
../src/providers/ldap/sdap.h:481:5: note: expected 'const char **' but argument is of type 'char **'
Fixed.
You need to add 'ignore_group_members' to the tuple of expected values in the test in SSSDConfigTest.py
D'oh, I actually had an open editor buffer with that change in it that it seems I lost track of and never saved 8-/.
Please indent the rest of the ?: structure so that it's clear that member_filter : NULL is part of the above. &state->attrs, NULL should be on the next line. It'll read easier that way.
Done.
!state->dom->ignore_group_members with a comment as to what that means? The if-then-else construct is a bit confusing there.
Good suggestion, I guess I had just had ternaries on my mind from the previous use :).
nsssrv_cmd.c has added a tab at the beginning of the line if (!dom->ignore_group_members) {
Oops, I try to play chameleon when working on other people's code bases but I guess my editor slipped that one past me.
I've attached an updated patch that I believe addresses all of your issues, let me know if I missed something or anything else needs a tuneup.
Thanks...