Re: [SSSD] [PATCH] Actually use the index parameter in resolv_get_sockaddr_address_index

[Jakub Hrozek]

On Tue, May 07, 2013 at 10:42:18AM +0200, Sumit Bose wrote:
> On Tue, May 07, 2013 at 09:52:17AM +0200, Jakub Hrozek wrote:
> > This bug was found by Sumit. When I split
> > resolv_get_sockaddr_address_index and resolv_get_sockaddr_address and
> > actually didn't use the index parameter anywhere.
>
> ACK, I only have I nano-nitpick, you might want to consider to rename
> index to addrindex in async_resolv.h as well, but this is purely
> cosmetically.
>
> bye,
> Sumit

You're right, I have squashed in the following change before pushing the
patch:

diff --git a/src/resolv/async_resolv.h b/src/resolv/async_resolv.h
index dd8e9de..a820788 100644
--- a/src/resolv/async_resolv.h
+++ b/src/resolv/async_resolv.h
@@ -131,7 +131,7 @@ resolv_get_string_ptr_address(TALLOC_CTX *mem_ctx,
 struct sockaddr_storage *
 resolv_get_sockaddr_address_index(TALLOC_CTX *mem_ctx,
                                   struct resolv_hostent *hostent,
-                                  int port, int index);
+                                  int port, int addrindex);