On Tue, Sep 01, 2015 at 11:06:59AM +0200, Jan Pazdziora wrote:
On Tue, Sep 01, 2015 at 11:00:26AM +0200, Jakub Hrozek wrote:
>
> Shall we push this patch to master since it looks correct code wise and
> doesn't look like it should regress anything or shall we wait for more
> complete solution in 1.14 that would also address domain-vs-realm
> concerns?
Is there a risk that the domain-vs-realm solution will cause us want
to revert this change? My feeling is it won't, so I'd vote for getting
it in master now.
I don't think the code the current patch touches would change, the
environment variable clearly states it's domain and the concept of
domains is very unlikely to change, ever.
Of course, the domain-vs-realm work can cause the codepaths that
populate the value to change but the value and its semantics is likely
to stay.
I think it's more likely there would be additional variables which might
render this one obsolete but in principle I agree.