URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations
sumit-bose commented: """ Testing went fine, but there is a "declared 'static' but never defined" issue. If this patch can be push with
diff --git a/src/sss_client/common.c b/src/sss_client/common.c index 676a1ba..b7a5ed7 100644 --- a/src/sss_client/common.c +++ b/src/sss_client/common.c @@ -1073,8 +1073,6 @@ struct sss_mutex { int old_cancel_state; };
-static void sss_nss_mc_mt_init(void); - static struct sss_mutex sss_nss_mtx = { .mtx = PTHREAD_MUTEX_INITIALIZER };
static struct sss_mutex sss_pam_mtx = { .mtx = PTHREAD_MUTEX_INITIALIZER };
It would be an ACK from me. """
See the full comment at https://github.com/SSSD/sssd/pull/46#issuecomment-262555532