On Wed, Jan 21, 2015 at 01:19:03PM +0100, Jakub Hrozek wrote:
On Tue, Jan 20, 2015 at 09:47:39PM +0100, Pavel Březina wrote:
On 01/20/2015 02:07 PM, Pavel Březina wrote:
On 01/20/2015 12:05 PM, Jakub Hrozek wrote:
On Tue, Jan 20, 2015 at 10:03:16AM +0100, Pavel Březina wrote:
On 01/19/2015 10:50 PM, Jakub Hrozek wrote:
>> >>confused..a subtree should be something further down the >>hierarchy, but >>here we're constructing a parent path, right? > >subtree of a parent path, see above
OK, I still think we should come up with a better name instead of "march". sbus_parent_wildcard() ?
[...]
How about sbus_opath_parent_subtree()?
Sounds good to me.
Here it is. I hope I addressed everything but the review mail was quite huge so it is possible I have missed something.
I'm sending the patch set one more time since a forgot to rename pvt to handler_data as requested. Also 8th patch did not contain latest changes since I left them unstaged.
Thank you, all my changes were addressed. ACK to all, pending Coverity and CI scans which are queued.
My testing consisted of several ordinary operation, testing that a service that received SEGV is restarted and testing that a service that was restarted due to a timeout works fine.
Sorry, but there are some Coverity warnings: sssd-1.12.90/src/sbus/sssd_dbus_connection.c:515: string_non_null: String literal ""org.freedesktop.DBus.Error.NoMemory"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:515: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NoMemory"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:507: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:507: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:527: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:527: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:538: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:538: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:501: string_non_null: String literal ""org.freedesktop.DBus.Error.UnknownMethod"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:501: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.UnknownMethod"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: notnull: At condition "dbus_error", the value of "dbus_error" cannot be "NULL". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: dead_error_condition: The condition "dbus_error" must be true. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: dead_error_line: Execution cannot reach the expression ""org.freedesktop.DBus.Error.Failed"" inside this statement: "reply = dbus_message_new_er...".
feel free to ping me if you need the full log (it's stored on a rh-internal machine, so not suitable for public ML)