URL:
https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
jhrozek commented:
"""
I'm sorry this PR review stalled (again :-/) but I've read the patches and I like
them now. I have two nitpicks, one was found by Coverity:
````
Error: CHECKED_RETURN (CWE-252):
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:307: check_return: Calling
"sssctl_run_command" without checking return value (as is done elsewhere 7 out
of 8 times).
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:108: example_assign: Example 1: Assigning:
"ret" = return value from "sssctl_run_command("sss_override
user-export /var/lib/sss/backup/sssd_user_overrides.bak")".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:110: example_checked: Example 1 (cont.):
"ret" has its value checked in "ret != 0".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:332: example_assign: Example 2: Assigning:
"ret" = return value from "sssctl_run_command(cmd)".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:333: example_checked: Example 2 (cont.):
"ret" has its value checked in "ret != 0".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:161: example_assign: Example 3: Assigning:
"ret" = return value from "sssctl_run_command("sss_override
user-import /var/lib/sss/backup/sssd_user_overrides.bak")".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:163: example_checked: Example 3 (cont.):
"ret" has its value checked in "ret != 0".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:170: example_assign: Example 4: Assigning:
"ret" = return value from "sssctl_run_command("sss_override
group-import /var/lib/sss/backup/sssd_group_overrides.bak")".
sssd-1.15.4/src/tools/sssctl/sssctl_data.c:172: example_checked: Example 4 (cont.):
"ret" has its value checked in "ret != 0".
sssd-1.15.4/src/tools/sssctl/sssctl_logs.c:292: example_assign: Example 5: Assigning:
"ret" = return value from "sssctl_run_command(cmd)".
sssd-1.15.4/src/tools/sssctl/sssctl_logs.c:293: example_checked: Example 5 (cont.):
"ret" has its value checked in "ret != 0".
# 305| fprintf(stderr, _("Missing option. \n"));
# 306| cachecmd = "sss_cache --help";
# 307|-> sssctl_run_command(cachecmd);
# 308| ret = EXIT_FAILURE;
# 309| goto done;
````
And the other I'll point out inline.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-329431797