Hi Stephen,
On 10/10/2013 10:46 PM, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote:
Make DEBUG macro accept variable number of arguments, thus removing the need to wrap the format string and its arguments into parens on invocation.
Nack.
Please do us a favor and split this into two patches, one that makes the change to the macro definition and one that bulk-updates the existing messages. Having a 2.2MB patch file with a few small changes buried in it somewhere is very difficult to review. I'm not confident I can locate the real changes amidst the find-replace noise.
This patch is already split out from the main macro change. It only does the absolute minimum needed to convert from a macro accepting arguments in parens to a variadic macro. These changes are limited to util.h. I did it this way, so you don't get a commit breaking the build.
However, I will split this commit into two and you can squash them together, if necessary.
Sincerely, Nick