URL:
https://github.com/SSSD/sssd/pull/5539
Title: #5539: [WIP] NSS: Clear negative cache when SIGHUP received
alexey-tikhonov commented:
"""
Hi,
@pbrezina , do you remember the reason to have ["clearMemcache"
method](https://github.com/SSSD/sssd/blob/master/src/sss_iface/sss_iface.... in
generic "sssd.service" interface instead of dedicated
["sssd.nss.MemoryCache"
interface](https://github.com/SSSD/sssd/blob/master/src/sss_iface/sss_ifa...
Perhaps the idea was that monitor should treat all services as "generic"
service, but that's not the case anyway:
https://github.com/SSSD/sssd/blob/master/src/monitor/monitor.c#L1351
What happens if this method is called but service doesn't implement it? Is there
"stub" handler or just NULL in method table?
---
@elkoniu , I understand it's tempting to copy what is done wrt mem-cache (though I
would suggest to check if there is a need/opportunity to improve things a bit), but even
in this case:
- IIUC, your implementation of `nss_clear_negcache()` isn't correct (see comment
inline)
- please take a look at those functions:
https://github.com/SSSD/sssd/blob/master/src/responder/common/negcache.h#... (and
[existing
interface](https://github.com/SSSD/sssd/blob/master/src/sss_iface/sss_ifa...)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5539#issuecomment-802304774