Re: [SSSD] [PATCH] Move and extend function for finding principal in keytab

[Stephen Gallagher]

On Wed, 2011-04-20 at 10:25 -0400, Stephen Gallagher wrote:
> On Tue, 2011-03-29 at 15:20 +0200, Jan Zelený wrote:
> > Stephen Gallagher  wrote:
> > > Nack.
> > >
> > > In match_principal(), use
> > > krb5_unparse_name_flags(ctx, principal,
> > >                         KRB5_PRINCIPAL_UNPARSE_NO_REALM,
> > >                         &primary);
> > >
> > > Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> > > latter is deprecated. This will also make your comparisons later
> > > somewhat easier, as krb5_principal_get_realm() returns a string instead
> > > of krb5_data.
> >
> > Fixed patch in attachment.
>
> Ack

Pushed to master.