URL:
https://github.com/SSSD/sssd/pull/5593
Title: #5593: BUILD: prefer PCRE2 over PCRE
alexey-tikhonov commented:
"""
Since we cannot use both libraries at once I wonder if it would be
more clear to only use `PCRE_LIBS` and `PCRE_CLAGS` and define them in the case libpcre2
is found as well?
That definitely would be more clean.
But those flags are set by `PKG_CHECK_MODULES`. Do you propose to do something like
`PCRE_LIBS = PCRE2_LIBS` "manually" in this case?
And btw I don't know what is the purpose of:
https://github.com/SSSD/sssd/blob/f5bbff2502b69dc5f37ba049025683fbd67d7bb...
-- is the same required for `PCRE2_LIBS`..?
But in general, I wouldn't bother much, because:
- currently either `PCRE_*` or `PCRE2_*` has value, and empty vars in makefile
doesn't seem to hurt
- we will remove support of PCRE-1 in next release entirely anyway
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5593#issuecomment-825507678