Martin Nagy wrote:
On Thu, 2009-09-17 at 19:21 +0200, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/17/2009 06:08 AM, Dmitri Pal wrote:
Dmitri Pal wrote:
See patch comments for details. All three are not massive.
- Comparison and sorting collections
The swapped != is certainly a bug: if ((res =! 0) && (out_flags == 0)) { if ((res =! 0) && (out_flags == 0)) {
I would advise against unneeded parentheses like in this case. If you wouldn't use them the compiler would warn you.
Martin
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
Are you sure they are unneeded? I will give it a try some time. It is just a habit of enclosing every logical statement in a separate pair of parentheses for me it helps to mentally evaluate the statement as I write it. I already do not remember whether it is just me and my habit or once was cause by some compiler reasons.