-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/02/2010 10:00 AM, Jakub Hrozek wrote:
On 02/26/2010 05:33 PM, Stephen Gallagher wrote:
> Nack.
> This is partly my fault. update_monitor_config() is broken and
> dangerous. I thought I had disabled all access to it. I didn't realize
> it was still running with SIGHUP.
> We disabled it a long while ago with the intent of fixing it eventually,
> but we ultimately decided that the downtime of a full restart was
> acceptable. I've been meaning to eliminate that code entirely.
Stephen eliminated that code in a separate patch which has been acked,
so the attached patches are rebased on top of his.
> Also, the *_rotate_logs() calls are all identical. They should just be
> made into a monitor_common_rotate_logs() call similar to
> monitor_common_res_init().
Done. I originally wanted to keep functions local to the separate
process (and its function namespace) but I agree that code duplication
is bad.
Jakub, I think you may have sent the wrong patch. 0001 does not apply
cleanly on top of the current master. Please check your rebase.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuP8ssACgkQeiVVYja6o6OIAACfbnF1YbQOkSUrg23JLWwfbin7
5k0AnjudKzjLUnJobj1J04XOpTaXIut1
=9ips
-----END PGP SIGNATURE-----