On (25/07/16 19:26), Jakub Hrozek wrote:
On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote:
> On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote:
> > Hi,
> >
> > this is my suggestion to solve
https://fedorahosted.org/sssd/ticket/2948
> > "Handle overriden name of members in the memberUid attribute".
>
> So far I read them to get a grasp of what they do, but didn't do a full
> review. See some comments below.
I also submitted the patches to Coverity which found a warning:
Error: COMPILER_WARNING:
Jakub,
As you can see it's not a coverity warning but COMPILER_WARNING(gcc)
sssd-1.14.1/src/util/util.h:54: included_from: Included from here.
sssd-1.14.1/src/db/sysdb_ops.c:22: included_from: Included from here.
sssd-1.14.1/src/db/sysdb_ops.c: scope_hint: In function
'sysdb_get_user_members_recursively'
sssd-1.14.1/src/db/sysdb_ops.c:4879:36: warning: format '%llu' expects argument of
type 'long long unsigned int', but argument 6 has type 'long unsigned int'
[-Wformat=]
# DEBUG(SSSDBG_CRIT_FAILURE, "More then [%llu] results.\n",
UINTMAX_MAX);
^^^^
According to inttypes.h
there should be PRIuMAX
But Do we really need UINTMAX_MAX?
or should we rather us UINT64_MAX
LS