On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas Slebodnik wrote:
On (04/10/15 21:51), Jakub Hrozek wrote:
>On Fri, Oct 02, 2015 at 11:26:33AM +0200, Lukas Slebodnik wrote:
>> ehlo,
>>
>> Attached patch should prevent such failures as in commit
>> 73ec8fdfddb2d4bf99977f758eec80e1b1ee8542
>> BUILD: Link test_data_provider_be with -ldl
>>
>> SSS_CRYPT_LIBS should not be part of SSSD_LIBS.
>> all necessary program and libraries should be linked with
>> libsss_cryto.so an do not use SSS_CRYPT_LIBS directly.
>>
>> LS
>
>Can you add a comment to the definition of SSS_CRYPT_LIBS saying that
>they shouldn't be used directly, but libsss_cryto should be used
>instead?
Is the comment sufficient?
LS
Thanks, that's exactly what I wanted.
Code-wise ACK, I'm waiting for CI to finish before pushing.