On 04/26/2011 07:16 PM, Stephen Gallagher wrote:
On Tue, 2011-04-26 at 17:37 +0200, Jakub Hrozek wrote:
I tested it against our corporate LDAP server plus my devel IPA server. Seems to work just fine.
I have two comments, though - ldap_create_page_control() and ldap_parse_pageresponse_control() don't seem to exist on RHEL5. We should probably #ifdef this functionality out (or implement it for old libldap releases).
Also the "paging_criticality" variable is char, but the iscritical parameter of ldap_parse_pageresponse_control() is declared as int.
The rest looks good to me.
Thanks for catching the paging_criticality bug. That was clearly wrong. I was working from some old IBM documentation that had it as a char. With the way I had it implemented before, it was incorrectly set as critical.
As for the comment about RHEL5, this is not an issue. RHEL 5.7 and later is shipping with openldap 2.4.24 (as an openldap24-libs RPM) that SSSD is linked against.
I'll open a bug against it, but I don't think it's urgent to fix it at present.
OK, I wasn't aware of this and I'm fine with this approach (and I'm glad I haven't ported back the deref parsing yet :-)).
Ack to all three patches.